Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid the change of podSets in Workload #256

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Forbid the change of podSets in Workload #256

merged 1 commit into from
Jun 28, 2022

Conversation

knight42
Copy link
Member

Signed-off-by: Jian Zeng anonymousknight96@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref #171 (comment)

Special notes for your reviewer:

@knight42
Copy link
Member Author

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2022
@denkensk denkensk mentioned this pull request May 12, 2022
Merged
denkensk
denkensk reviewed May 25, 2022
View reviewed changes
Copy link
Member

@denkensk denkensk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some comments.

apis/kueue/v1alpha1/workload_webhook_test.go Outdated Show resolved Hide resolved
apis/kueue/v1alpha1/workload_webhook_test.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor

ahg-g commented Jun 15, 2022

friendly ping

@knight42
Copy link
Member Author

@ahg-g Sorry for the late response, I have been busy these days 😢 . I would get back to my PRs at this weekend.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2022
@knight42
Copy link
Member Author

@ahg-g @kerthcet @denkensk Hi! Would you like to take another look?

@ahg-g
Copy link
Contributor

ahg-g commented Jun 27, 2022

yes, sorry I didn't get notified that the comments were addressed

@ahg-g
Copy link
Contributor

ahg-g commented Jun 27, 2022

thanks, please squash

@knight42
feat(validate): forbid the change of podSets in Workload
01475de 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42
Copy link
Member Author

@ahg-g Hi! I have squashed the commits.

@kerthcet
Copy link
Contributor

thanks @knight42
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2022
@ahg-g
Copy link
Contributor

ahg-g commented Jun 28, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, knight42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit cb409f6 into kubernetes-sigs:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk denkensk left review comments

@kerthcet kerthcet kerthcet left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@kerthcet kerthcet

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@knight42 @ahg-g @kerthcet @k8s-ci-robot @alculquicondor @denkensk