Provide Kubeflow PyTorchJob support for MultiKueue #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
mszadkow
force-pushed
the
feature/support-kubeflow-pytorch-in-mk
branch
from
7384585
to
48c87ee
Compare
|
/retest |
trasc
reviewed
Aug 1, 2024
| @@ -459,6 +460,88 @@ var _ = ginkgo.Describe("MultiKueue", func() { | |||
| }, util.Timeout, util.Interval).Should(gomega.Succeed()) | |||
| }) | |||
| }) | |||
|
|
|||
| ginkgo.It("Should run a kubeflow PyTorchJob on worker if admitted", func() { | |||
| pyTorchJob := testingpytorchjob.MakePyTorchJob("pytorchjob1", managerNs.Name). | |||
There was a problem hiding this comment.
Add a comment on the worker we expect o run it and why
(nit: maybe we should make this one run in worker 2)
There was a problem hiding this comment.
make sense I will update in all of the jobs
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8b2a8a046c07026986cb8e09ed8681b1410ba595
|
tenzen-y
reviewed
Aug 2, 2024
pkg/controller/jobs/kubeflow/jobs/pytorchjob/pytorch_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
pkg/controller/jobs/kubeflow/jobs/pytorchjob/pytorch_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
pkg/controller/jobs/kubeflow/jobs/pytorchjob/pytorch_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
pkg/controller/jobs/kubeflow/jobs/pytorchjob/pytorch_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
mszadkow
force-pushed
the
feature/support-kubeflow-pytorch-in-mk
branch
from
6671628
to
68dc6da
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 843db76576fd6082359d2e4e65f56ae3ceb85518
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mszadkow, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The PR introduces a new MultiKueue adapter to handle PyTorchJob (Kubeflow).
We want to extend MultiKueue capabilities to satisfy the needs of early adopters.
Which issue(s) this PR fixes:
Relates #2552
Special notes for your reviewer:
Does this PR introduce a user-facing change?