Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kjobctl] Add a localqueue filter to the list job command. #2736

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jul 31, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a localqueue filter to the list job command on kjobctl.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2024
@k8s-ci-robot k8s-ci-robot requested review from denkensk and mimowo July 31, 2024 19:59
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2024
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ac5dc43
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66aa986e46a2ec0008edf0b2

@mbobrovskyi mbobrovskyi force-pushed the feature/kjobctl-add-localqueue-filter-on-list-job-command branch from 853d7ee to ac5dc43 Compare July 31, 2024 20:02
@mszadkow
Copy link
Contributor

mszadkow commented Aug 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9932f973324f9100153d4afea70876e1d8d9c31b

Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3eead6 into kubernetes-sigs:main Aug 2, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Aug 2, 2024
@mbobrovskyi mbobrovskyi deleted the feature/kjobctl-add-localqueue-filter-on-list-job-command branch August 2, 2024 08:58
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/release-note-edit

kjobctl: Support `--profile` and `--local queue` options for the listing jobs, which are used for filtering out listed jobs.

@tenzen-y
Copy link
Member

/release-note-edit

kjobctl: Support `--profile` and `--local queue` options for the listing jobs, which are used to filter out listed jobs.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 14, 2024
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2024

/release-note-edit

NONE

No need for release note as kjobctl isn't released as part of Kueue. We consider to move it out here #2778

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 30, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants