Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move declaration of the Preempted reasons to API pkg #2814

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Aug 12, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. for consistency - reasons for all other conditions (for example WorkloadEvicted) are in the API package
  2. to enable Kueue to make decisions based on the conditions from every package. In particular, when working on Fix using PrioritySortingWithinCohort=false and borrowWithinCohort #2807 I consider to use the reclaimWhileBorrowing reason

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I left HumanReadablePreemptionReasons, because this is used to build messages. Kueue should not make decisions based on messages, and most messages are not part of the API packages anyway.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from denkensk and trasc August 12, 2024 07:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2024
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8722f07
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66b9e57f87fd060008775a79

@mimowo
Copy link
Contributor Author

mimowo commented Aug 12, 2024

/assign @gabesaba

@mimowo mimowo force-pushed the move-preemption-reasons branch from cb68d9d to e301f8f Compare August 12, 2024 09:56
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!
I left a comment for a nit.

@mimowo mimowo force-pushed the move-preemption-reasons branch from e301f8f to 8722f07 Compare August 12, 2024 10:35
@tenzen-y
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 21fc0e36d6776db8599a6d1bafb53dc50ab2a8bb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af0c645 into kubernetes-sigs:main Aug 12, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Aug 12, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mimowo mimowo deleted the move-preemption-reasons branch January 21, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants