-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move declaration of the Preempted reasons to API pkg #2814
Move declaration of the Preempted reasons to API pkg #2814
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @gabesaba |
cb68d9d
to
e301f8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
I left a comment for a nit.
e301f8f
to
8722f07
Compare
/lgtm |
LGTM label has been added. Git tree hash: 21fc0e36d6776db8599a6d1bafb53dc50ab2a8bb
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I left HumanReadablePreemptionReasons, because this is used to build messages. Kueue should not make decisions based on messages, and most messages are not part of the API packages anyway.
Does this PR introduce a user-facing change?