Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cardinality of pending_workloads metric #293

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

alculquicondor
Copy link
Contributor

@alculquicondor alculquicondor commented Jul 8, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Remove the queue label from the pending_workloads metric.

As opposed to ClusterQueues, Queues are more likely to be unbounded by administrators, which could lead to cardinality explosion.
OTOH, administrators are more likely to care about metrics per ClusterQueue. Users, who might be the owners of Queues, might not even have access to metrics. They can still check the Queue status.

Which issue(s) this PR fixes:

Ref #291 (comment)

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2022
@alculquicondor
Copy link
Contributor Author

/assign @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Jul 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 87339ad into kubernetes-sigs:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants