Reduce cardinality of pending_workloads metric #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
alculquicondor
force-pushed
the
rm-queue-key
branch
from
db82e3a
to
b9ca736
Compare
|
/assign @ahg-g |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Remove the
queuelabel from thepending_workloadsmetric.As opposed to ClusterQueues, Queues are more likely to be unbounded by administrators, which could lead to cardinality explosion.
OTOH, administrators are more likely to care about metrics per ClusterQueue. Users, who might be the owners of Queues, might not even have access to metrics. They can still check the Queue status.
Which issue(s) this PR fixes:
Ref #291 (comment)
Special notes for your reviewer: