Support Cohorts with Resources in cache/hierarchy packages #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/L
|
/assign @macsko |
gabesaba
force-pushed
the
cache_resource_cohort
branch
from
0924890
to
e4dcb28
Compare
macsko
reviewed
Sep 2, 2024
| wantCohorts: sets.New("cohort"), | ||
| wantCqs: sets.New("queue"), | ||
| wantCqEdge: []cqEdge{{"queue", "cohort"}}, | ||
| }, |
There was a problem hiding this comment.
What about testing the cleanupCohort method? Like:
m.AddCohort(newCohort("cohort"))
m.AddClusterQueue(newCq("queue"))
m.UpdateClusterQueueEdge("queue", "cohort")
m.DeleteCohort("cohort")
m.DeleteClusterQueue("queue")
pkg/hierarchy/manager.go
Outdated
| } | ||
|
|
||
| // rewireChildren is used when we are changing a Cohort | ||
| // from an implicit to an explcit Cohort, or vice-versa. |
pkg/cache/cache.go
Outdated
| defer c.Unlock() | ||
| c.hm.DeleteCohort(apiCohort.Name) | ||
|
|
||
| // if the cohort still exists after deletion, it means |
gabesaba
force-pushed
the
cache_resource_cohort
branch
from
e4dcb28
to
bcdebab
Compare
k8s-ci-robot
added
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5c6066569fcfec1b165141c8c4c496c8ae093556
|
gabesaba
commented
Sep 3, 2024
| @@ -57,6 +57,9 @@ issues: | |||
| - staticcheck | |||
| # TODO(#768): Drop when incrementing the API version. | |||
| text: "SA1019: constants.QueueAnnotation is deprecated" | |||
| - linters: | |||
There was a problem hiding this comment.
tracking here: #2965
|
/assign @mimowo |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update cache to support Cohorts with resources. Update hierarchy to support explicit Cohorts. Part of #79
Special notes for your reviewer:
commit 1 : move files and refactor parsing
commit 2: support Cohorts which provide resources in
cache. support explicit Cohorts inhierarchyUsers cannot use this functionality until we wire up reconciler and webhook. In the interest of keeping PRs small, I will publish those in separate PRs.
Does this PR introduce a user-facing change?