Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snapshoting to use hierarchy.Manager #2989

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

gabesaba
Copy link
Contributor

@gabesaba gabesaba commented Sep 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This change simplifies edge management in the Snapshot. This will allow us, in a simple manner, to snapshot and create edges between HierarchicalCohorts (#79) in a subsequent PR.

Special notes for your reviewer:

Hide ws diff when reviewing snapshot_test.go

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 42dab87
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66d97e5be732700008a471bc
😎 Deploy Preview https://deploy-preview-2989--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2024
@gabesaba
Copy link
Contributor Author

gabesaba commented Sep 5, 2024

/assign @mimowo

@mimowo
Copy link
Contributor

mimowo commented Sep 5, 2024

@gabesaba
Copy link
Contributor Author

gabesaba commented Sep 5, 2024

@mimowo
Copy link
Contributor

mimowo commented Sep 5, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45e189ef66e85060d2f2cae6b3fa59323197a29c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit d40b300 into kubernetes-sigs:main Sep 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 5, 2024
@gabesaba gabesaba deleted the rewire_snapshot branch September 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants