-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Snapshoting to use hierarchy.Manager #2989
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @mimowo |
This looks like a flake: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/2989/pull-kueue-test-e2e-main-1-31/1831630396710719488. Please open an issue. |
#2990 |
/lgtm |
LGTM label has been added. Git tree hash: 45e189ef66e85060d2f2cae6b3fa59323197a29c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This change simplifies edge management in the Snapshot. This will allow us, in a simple manner, to snapshot and create edges between HierarchicalCohorts (#79) in a subsequent PR.
Special notes for your reviewer:
Hide ws diff when reviewing snapshot_test.go
Does this PR introduce a user-facing change?