Add the finalizer via webhook when creating resourceFlavor #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/L
kerthcet
force-pushed
the
feat/add-webhook-to-resourceFlavor
branch
from
ff7dfc1
to
0a5c402
Compare
main.go
Outdated
| @@ -177,6 +177,10 @@ func setupControllers(mgr ctrl.Manager, cCache *cache.Cache, queues *queue.Manag | |||
| setupLog.Error(err, "unable to create webhook", "webhook", "Workload") | |||
| os.Exit(1) | |||
| } | |||
| if err := (&kueuev1alpha1.ResourceFlavor{}).SetupWebhookWithManager(mgr); err != nil { | |||
There was a problem hiding this comment.
We should have a function in pkg/controller/core that adds all the webhooks
There was a problem hiding this comment.
I was intended to add this when adding webhook to clusterQueue, in this pr is fine too.
test/integration/controller/core/resourceflavor_controller_test.go
Outdated
Show resolved
Hide resolved
kerthcet
force-pushed
the
feat/add-webhook-to-resourceFlavor
branch
from
deaa278
to
95f98ed
Compare
ahg-g
reviewed
Jul 18, 2022
ahg-g
reviewed
Jul 19, 2022
k8s-ci-robot
added
the
needs-rebase
kerthcet
force-pushed
the
feat/add-webhook-to-resourceFlavor
branch
from
d552944
to
88211b2
Compare
k8s-ci-robot
removed
the
needs-rebase
|
pls squash |
1 similar comment
|
pls squash |
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
feat/add-webhook-to-resourceFlavor
branch
from
88211b2
to
05174cb
Compare
|
squashed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #283
Special notes for your reviewer: