-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Add cohorts CRD in the kustomization #2995
[config] Add cohorts CRD in the kustomization #2995
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The change lgtm, but can you explain why this omission is causing MK the tests to flake? Would the single cluster tests also flake? |
cc @gabesaba |
Because the Cohorts CRDs are not installed, the controller runtime periodically kills the controller manager.
Intended this is not related to multikueue and is the cause for other farriers for the same PR. |
Thanks for the clarification |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 0ae8aa2f333031d9622477acb695854493f5520a
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
[config] Add cohorts CRD in the kustomization. (missed in #2693)
Which issue(s) this PR fixes:
Fixes #2981
Special notes for your reviewer:
Does this PR introduce a user-facing change?