Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Add cohorts CRD in the kustomization #2995

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Sep 5, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

[config] Add cohorts CRD in the kustomization. (missed in #2693)

Which issue(s) this PR fixes:

Fixes #2981

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit de70a2d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66d9af2c1826b600088df16e
😎 Deploy Preview https://deploy-preview-2995--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Sep 5, 2024

The change lgtm, but can you explain why this omission is causing MK the tests to flake? Would the single cluster tests also flake?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2024
@alculquicondor
Copy link
Contributor

cc @gabesaba

@trasc
Copy link
Contributor Author

trasc commented Sep 5, 2024

The change lgtm, but can you explain why this omission is causing MK the tests to flake? Would the single cluster tests also flake?

Because the Cohorts CRDs are not installed, the controller runtime periodically kills the controller manager.

2024-09-04T13:49:46.73520991Z stderr F 2024-09-04T13:49:46.735096309Z	ERROR	setup	kueue/main.go:195	Could not run manager	{"error": "failed to wait for cohort caches to sync: timed out waiting for cache to be synced for Kind *v1alpha1.Cohort"}

Intended this is not related to multikueue and is the cause for other farriers for the same PR.

@alculquicondor
Copy link
Contributor

Thanks for the clarification
/approve

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ae8aa2f333031d9622477acb695854493f5520a

@k8s-ci-robot k8s-ci-robot merged commit 31b0603 into kubernetes-sigs:main Sep 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 5, 2024
@trasc trasc deleted the add-cohorts-to-kustomize branch September 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky MultiKueue e2e Test
4 participants