-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validations to clusterQueue resource name #309
add validations to clusterQueue resource name #309
Conversation
Reduce the complexity of validations of resource name, we can add more rules when needed in the future. |
Can we add the other validations to this PR now that it become simpler after removing the strict name validation? |
Leave the |
@ahg-g PTAL |
defer func() { | ||
var newCQ kueue.ClusterQueue | ||
gomega.Expect(k8sClient.Get(ctx, client.ObjectKeyFromObject(cq), &newCQ)).Should(gomega.Succeed()) | ||
controllerutil.RemoveFinalizer(&newCQ, kueue.ResourceInUseFinalizerName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we explicitly remove the finalizer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have no controller in webhook integration tests.
Addressed the comments. |
Thanks, pls squash |
Signed-off-by: kerthcet <kerthcet@gmail.com>
ca8fc8e
to
c1a3d1c
Compare
Done :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is part of #171.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: