Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "KEP-168-pending-workload-visibility" before deprecation. #3112

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions keps/168-pending-workloads-visibility/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ tags, and then generate with `hack/update-toc.sh`.
- [Unit Tests](#unit-tests)
- [Integration tests](#integration-tests)
- [Graduation Criteria](#graduation-criteria)
- [Beta](#beta)
- [Stable](#stable)
- [Alpha](#alpha)
- [Deprecation](#deprecation)
- [Implementation History](#implementation-history)
- [Drawbacks](#drawbacks)
- [Alternatives](#alternatives)
Expand Down Expand Up @@ -515,7 +515,7 @@ After the implementation PR is merged, add the names of the tests here.

### Graduation Criteria

#### Beta
#### Alpha

First iteration (0.5):

Expand All @@ -530,9 +530,19 @@ Third iteration (0.7):

- reevaluate the need for exposing positions and support if needed

#### Stable
#### Deprecation

- drop the feature gate
We deprecate the feature, and going to remove it in feature versions of the API,
in favor of monitoring pending workloads using the [on-demand visibility API](https://kueue.sigs.k8s.io/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand/).

First iteration (0.9):

- deprecate the QueueVisibility feature gate and corresponding API.

Second iteration (v1beta2):

- remove the QueueVisibility feature gate,
- remove PendingWorkloadsStatus field from ClusterQueue object and QueueVisibility field from Config object on bumping the API version.

<!--

Expand Down
11 changes: 7 additions & 4 deletions keps/168-pending-workloads-visibility/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@ approvers:
- "@ahg-g"
- "@alculquicondor"

stage: beta
see-also:
- "/keps/168-2-pending-workloads-visibility"

latest-milestone: "v0.5"
stage: deprecated

latest-milestone: "v0.9"

milestone:
beta: "v0.5"
stable: "v0.8"
alpha: "v0.5"
deprecated: "v0.9"

disable-supported: true

Expand Down