Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix has malformed LC_DYSYMTAB warning on darwin platform. #3202

Merged

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Oct 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix has malformed LC_DYSYMTAB warning on darwin platform.

Which issue(s) this PR fixes:

Fixes #3196

Special notes for your reviewer:

When we running make test on Darwing platform we have warnings:

=== Errors
ld: warning: '/private/var/folders/y3/rwbwnplx2cz9gf0t71dhp5k00000gn/T/go-link-3229174941/000012.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
ld: warning: '/private/var/folders/y3/rwbwnplx2cz9gf0t71dhp5k00000gn/T/go-link-2692282886/000012.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
ld: warning: '/private/var/folders/y3/rwbwnplx2cz9gf0t71dhp5k00000gn/T/go-link-3121826813/000012.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
ld: warning: '/private/var/folders/y3/rwbwnplx2cz9gf0t71dhp5k00000gn/T/go-link-103183806/000012.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
ld: warning: '/private/var/folders/y3/rwbwnplx2cz9gf0t71dhp5k00000gn/T/go-link-4253876968/000012.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626

We can fix it using GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic" as described here.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc October 9, 2024 08:47
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6ed0b0b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67064397c40d890008abc5eb

@mbobrovskyi mbobrovskyi force-pushed the fix/has-malformed-LC_DYSYMTAB-error branch from 7d1a7ea to 6ed0b0b Compare October 9, 2024 08:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
@mbobrovskyi mbobrovskyi changed the title Fix has malformed LC_DYSYMTAB warning on darwin platform. Fix has malformed LC_DYSYMTAB warning on darwin platform. Oct 9, 2024
@mbobrovskyi
Copy link
Contributor Author

cc: @akram

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aba9d767d3b682bc4e53bb2451fd7302f8f25766

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit ecc626f into kubernetes-sigs:main Oct 9, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Oct 9, 2024
@mbobrovskyi mbobrovskyi deleted the fix/has-malformed-LC_DYSYMTAB-error branch October 9, 2024 11:13
@akram
Copy link
Contributor

akram commented Oct 9, 2024

thanks folks ; that's awesome

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running make test on MacOS Sonoma with golang go1.22.5 errors with has malformed LC_DYSYMTAB error
4 participants