-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix has malformed LC_DYSYMTAB
warning on darwin platform.
#3202
Fix has malformed LC_DYSYMTAB
warning on darwin platform.
#3202
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
7d1a7ea
to
6ed0b0b
Compare
has malformed LC_DYSYMTAB
warning on darwin platform.
cc: @akram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
/approve
LGTM label has been added. Git tree hash: aba9d767d3b682bc4e53bb2451fd7302f8f25766
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks folks ; that's awesome |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix
has malformed LC_DYSYMTAB
warning on darwin platform.Which issue(s) this PR fixes:
Fixes #3196
Special notes for your reviewer:
When we running
make test
on Darwing platform we have warnings:We can fix it using GOFLAGS="-ldflags=-extldflags=-Wl,-ld_classic" as described here.
Does this PR introduce a user-facing change?