Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Maximum execution time #3308

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Oct 24, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add documentation for Maximum execution time.

Which issue(s) this PR fixes:

Fixes #3125

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit aafd7df
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6728818c8c53d800089c799f
😎 Deploy Preview https://deploy-preview-3308--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trasc
Copy link
Contributor Author

trasc commented Oct 24, 2024

/hold
for #3191 and #3200

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@trasc trasc marked this pull request as ready for review October 24, 2024 14:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@tenzen-y
Copy link
Member

I will review this in the next week.

@trasc
Copy link
Contributor Author

trasc commented Oct 25, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@trasc trasc force-pushed the max-exec-time-doc branch from 41f2ab7 to aafd7df Compare November 4, 2024 08:10
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4ec3a3405e122ef6213d434668897fde1efe8c7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a67f2b1 into kubernetes-sigs:main Nov 4, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Nov 4, 2024
@mbobrovskyi mbobrovskyi deleted the max-exec-time-doc branch November 4, 2024 10:02
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/release-note-note
I believe no need for release note as this is a new feature so one entry about it is enough,

@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 5, 2024
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
* [doc] Maximum execution time

* Review Remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Job-agnostic API to declare the maximal execution time for a Job
5 participants