Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mutating queue name in Deployment Webhook. #3528

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Allow mutating queue name in Deployment Webhook. #3528

merged 2 commits into from
Nov 25, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Nov 13, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow mutating queue name in Deployment Webhook.

Which issue(s) this PR fixes:

Fixes #3552

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow mutating the queue-name label for non-running Deployments.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c2426ca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6740448adf05400008601d0c

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 13, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch from e5b7db3 to 40d8aa6 Compare November 13, 2024 21:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch 5 times, most recently from df84a3e to db1a636 Compare November 14, 2024 05:49
@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 14, 2024 05:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch from db1a636 to bad767d Compare November 14, 2024 06:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 21, 2024 •
edited
Loading

It will not work if user want to remove queue-name label.

I know, but mutating is probably a more common use-case than deleting, and would let us handle these two scenarios independently

@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch 2 times, most recently from fcf3de6 to 69e036e Compare November 21, 2024 12:17
mimowo
mimowo reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have e2e test for that? When renaming from non-existing to existing queue-name

@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch from 69e036e to bb5e82f Compare November 21, 2024 13:34
@mbobrovskyi
Copy link
Contributor Author

Can we also have e2e test for that? When renaming from non-existing to existing queue-name

Oh, I found another problem. When Pods have Scheduling Gates and we update them through the Deployment, both the Pods and the Workloads get stuck. I will try to fix it, but I’ll need a reconciler for that.

/hold to fix this issue.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch 3 times, most recently from ba6e05a to 049a5a4 Compare November 22, 2024 05:59
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch from 049a5a4 to cae6094 Compare November 22, 2024 06:17
@mbobrovskyi
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/manageJobsWithoutQueueName-deployment branch from 79a4b53 to c2426ca Compare November 22, 2024 08:44
mimowo
mimowo reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 388d6c014f42f3a0a328bffaa964bda43b90453f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 25, 2024

/release-note-edit

Allow mutating the queue-name label for non-running Deployments.

@mimowo
Copy link
Contributor

mimowo commented Nov 25, 2024

/retest
Issue opened: #3620

@k8s-ci-robot k8s-ci-robot merged commit 21da6ee into kubernetes-sigs:main Nov 25, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 25, 2024
@trasc trasc deleted the fix/manageJobsWithoutQueueName-deployment branch November 25, 2024 11:55
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
@mbobrovskyi @kannon92
Allow mutating queue name in Deployment Webhook. (kubernetes-sigs#3528)
bfd0b20 
* Allow mutating queue name in Deployment Webhook.

* Review remarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss left review comments

@mimowo mimowo mimowo left review comments

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@PBundyra PBundyra Awaiting requested review from PBundyra

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Allow mutating queue name in Deployment Webhook.
4 participants
@mbobrovskyi @k8s-ci-robot @mimowo @dgrove-oss