Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MXJob from Kueue code #4077

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Remove MXJob from Kueue code #4077

merged 1 commit into from
Jan 28, 2025

Conversation

mszadkow
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As agreed in the discussion,
before we update Kubeflow to v1.9.0 we first remove the support for MXJob.

Which issue(s) this PR fixes:

Relates to #2552

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove the support for Kubeflow MXJob.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2025
@mszadkow mszadkow force-pushed the cleanup/remove-kubeflow-mxjob-support branch from f6d2319 to 63be725 Compare January 28, 2025 12:11
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit f6d2319
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6798c93aaa410800087495aa
😎 Deploy Preview https://deploy-preview-4077--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mszadkow mszadkow marked this pull request as ready for review January 28, 2025 12:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@mszadkow mszadkow mentioned this pull request Jan 28, 2025
Merged
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 89c0aa3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6798fd62219b1b00087fad47
😎 Deploy Preview https://deploy-preview-4077--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mbobrovskyi
mbobrovskyi reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mbobrovskyi mbobrovskyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove this line:

kueue/site/static/_redirects

Line 27 in 63be725

/docs/tasks/run_kubeflow_jobs/run_mxjobs /docs/tasks/run/kubeflow/mxjobs 301

@mszadkow mszadkow force-pushed the cleanup/remove-kubeflow-mxjob-support branch from 63be725 to d6565e5 Compare January 28, 2025 13:11
@mbobrovskyi
Copy link
Contributor

@mszadkow Could you please resolve conflicts?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@mszadkow mszadkow force-pushed the cleanup/remove-kubeflow-mxjob-support branch from d6565e5 to 89c0aa3 Compare January 28, 2025 15:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@mbobrovskyi
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: adf9e07198e36ae46a54e3990e99e880c7836b2d

@mimowo
Copy link
Contributor

mimowo commented Jan 28, 2025

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 595cf00 into kubernetes-sigs:main Jan 28, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Jan 28, 2025
@mszadkow mszadkow deleted the cleanup/remove-kubeflow-mxjob-support branch January 28, 2025 16:15
FillZpp pushed a commit to leptonai/kueue that referenced this pull request Feb 5, 2025
@mszadkow @FillZpp
Remove MXJob from Kueue code (kubernetes-sigs#4077)
2da2c47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@mimowo mimowo Awaiting requested review from mimowo

@PBundyra PBundyra Awaiting requested review from PBundyra

@gabesaba gabesaba Awaiting requested review from gabesaba

Assignees

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@mszadkow @k8s-ci-robot @mbobrovskyi @mimowo