Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile add arguments for img building and pushing #51

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

example on with my setup

[eduardo@fedora kueue]$ make image-build                                                                                                                                                   [54/1922]
buildah bud -t quay.io/eduardoarango/kueue:21194b5-dirty \
        --build-arg BASE_IMAGE=gcr.io/distroless/static:nonroot \                              
        --build-arg BUILDER_IMAGE=golang:1.17 \                                                
         \                          
         ./                            
[1/2] STEP 1/9: FROM golang:1.17 AS builder
Trying to pull docker.io/library/golang:1.17...                                         
Getting image source signatures
Copying blob 412caad352a3 skipped: already exists  
Copying blob e6d3e61f7a50 skipped: already exists  
Copying blob 9297634c9537 skipped: already exists  
Copying blob 461bb1d8c517 skipped: already exists  
Copying blob 0c6b8ff8c37e skipped: already exists  
Copying blob 378ec17cbe4c done  
Copying blob e6ff4e95ec2f done  
Copying config 836f6d7d89 done  
Writing manifest to image destination
Storing signatures
[1/2] STEP 2/9: WORKDIR /workspace
[1/2] STEP 3/9: COPY go.mod go.mod
[1/2] STEP 4/9: COPY go.sum go.sum
[1/2] STEP 5/9: RUN go mod download
[1/2] STEP 6/9: COPY main.go main.go
[1/2] STEP 7/9: COPY api/ api/
[1/2] STEP 8/9: COPY pkg/ pkg/
[1/2] STEP 9/9: RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go
[2/2] STEP 1/5: FROM gcr.io/distroless/static:nonroot
[2/2] STEP 2/5: WORKDIR /
[2/2] STEP 3/5: COPY --from=builder /workspace/manager .
[2/2] STEP 4/5: USER 65532:65532
[2/2] STEP 5/5: ENTRYPOINT ["/manager"]
[2/2] COMMIT quay.io/eduardoarango/controller:21194b5-dirty
Getting image source signatures
Copying blob 5b1fa8e3e100 skipped: already exists  
Copying blob 160339bf3e6b done  
Copying config 943ad44513 done  
Writing manifest to image destination
Storing signatures
--> 943ad44513c
Successfully tagged quay.io/eduardoarango/kueue:21194b5-dirty
943ad44513cdd39f082c15dff7fbf0f117fb1f0c9c124a54e6581ea770a98359

Which issue(s) this PR fixes:

Fixes #47

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2022
@ArangoGutierrez
Copy link
Contributor Author

off course test will fail :) catch 22 PR

@ArangoGutierrez
Copy link
Contributor Author

/test pull-kueue-build-image-main

Copy link
Contributor Author

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve suggestions

@alculquicondor
Copy link
Contributor

Please squash

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Aldo Culquicondor
@ArangoGutierrez
Copy link
Contributor Author

squash'ed ✅

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 625f977 into kubernetes-sigs:main Feb 22, 2022
ChristianZaccaria pushed a commit to ChristianZaccaria/kueue that referenced this pull request Jan 14, 2025
…mmadiIram-patch-3

Update Dockerfile.konflux with tag+digest for golang-builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Makefile arguments for img building and pushing
3 participants