fix(plugins/plugin-client-common): Hint component can generate invali…

…d dom nesting warning part of #7963
kubernetes-sigs · Sep 13, 2021 · a198c9d · a198c9d
1 parent e7eb729
commit a198c9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/plugins/plugin-client-common/src/components/Content/Markdown.tsx b/plugins/plugin-client-common/src/components/Content/Markdown.tsx
@@ -258,10 +258,11 @@ export default class Markdown extends React.PureComponent<Props> {
               }
             },
             blockquote: props => {
+              // avoid <p>: invalid dom nesting of p inside of p
               return (
-                <p>
+                <span className="paragraph">
                   <Hint>{props.children}</Hint>
-                </p>
+                </span>
               )
             },
             code: props => {

diff --git a/plugins/plugin-client-common/web/scss/components/Terminal/Commentary.scss b/plugins/plugin-client-common/web/scss/components/Terminal/Commentary.scss
@@ -47,7 +47,8 @@
 
 @mixin Paragraphs {
   @include CommentaryCard {
-    p {
+    p,
+    .paragraph {
       @content;
     }
   }