Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUI webpack UI fails to display on Microsoft Edge browser with v5.1.7 #3014

Closed
mark-nc opened this issue Oct 16, 2019 · 8 comments · Fixed by #3015
Closed

KUI webpack UI fails to display on Microsoft Edge browser with v5.1.7 #3014

mark-nc opened this issue Oct 16, 2019 · 8 comments · Fixed by #3015

Comments

@mark-nc
Copy link

mark-nc commented Oct 16, 2019

Describe the bug
When displaying our webpack version of KUI served up from a proxy running in a Kubernetes pod container on a Microsoft Edge browser, the UI fails to display due to an error.

SCRIPT1028: SCRIPT1028: Expected identifier, string or number main.f5ff389ec0d128f0e162.bundle.js (216282,3)

Expected behavior
The UI should display on the Edge browser.

Screenshots
image

System

  • Kui version: 5.1.7
  • Operating system: Windows 10 Professional
@starpit
Copy link
Contributor

starpit commented Oct 16, 2019

thanks for the bug report. this seems to come about due to an upgrade of a dependence (electron-context-menu) that itself upgrade one of its dependences; that transitive dependence (cli-truncate v2.0.0) included a change that is incompatible with edge. this dependence isn't needed for webpack builds, so we will find a way to remove it. if not, we can always downgrade the version of that dependence.

starpit added a commit to starpit/kui that referenced this issue Oct 16, 2019
@starpit
fix(packages/core): eliminate repl/exec -> spawn-electron import path
72b90c2 
this should resolve an issue with spawn-electron's dependence on electron-context-menu, which has a dependence on cli-truncate that (with v2.0.0 of cli-truncate) is no longer compatible with edge.

Fixes kubernetes-sigs#3014
@starpit starpit mentioned this issue Oct 16, 2019
Merged
7 tasks
starpit added a commit that referenced this issue Oct 16, 2019
@starpit
fix(packages/core): eliminate repl/exec -> spawn-electron import path
10d0e77 
this should resolve an issue with spawn-electron's dependence on electron-context-menu, which has a dependence on cli-truncate that (with v2.0.0 of cli-truncate) is no longer compatible with edge.

Fixes #3014
@showeimer
Copy link

Problem still persists on v5.1.9

Screen Shot 2019-10-21 at 11 47 58 AM

Screen Shot 2019-10-21 at 11 48 05 AM

@starpit
Copy link
Contributor

starpit commented Oct 21, 2019

thanks! can you try to figure out the call stack that leads to this error?

@starpit starpit reopened this Oct 21, 2019
@mark-nc
Copy link
Author

mark-nc commented Oct 21, 2019

Can you point a browser against your webpack sample? That might make it easier to find in your own test environment?

@starpit
Copy link
Contributor

starpit commented Oct 21, 2019

i'm still trying to figure out how to get a windows vm to talk to a web server running on the enclosing host.

i did experiment with a webpack build to see if the offending code would ever load. on firefox, i have yet to see this happen.

@starpit starpit mentioned this issue Oct 21, 2019
Closed
starpit added a commit to starpit/kui that referenced this issue Oct 21, 2019
@starpit
fix(packages/core): remove electron-context-menu dependence
628a936 
also electron-squirrel-starutp
Fixes kubernetes-sigs#3064

the former is causing problems with Edge
Fixes kubernetes-sigs#3014
starpit added a commit to starpit/kui that referenced this issue Oct 22, 2019
@starpit
fix(packages/core): remove electron-context-menu dependence
a73d67e 
also electron-squirrel-starutp
Fixes kubernetes-sigs#3064

the former is causing problems with Edge
Fixes kubernetes-sigs#3014
starpit added a commit that referenced this issue Oct 22, 2019
@starpit
fix(packages/core): remove electron-context-menu dependence
4efac45 
also electron-squirrel-starutp
Fixes #3064

the former is causing problems with Edge
Fixes #3014
@showeimer
Copy link

KUI 5.1.11 still broken with same syntax issue somewhere else; I think KUI will need to modify the compiler to support these more modern JS features.

Screen Shot 2019-10-22 at 9 59 26 AM

Screen Shot 2019-10-22 at 9 59 37 AM

@mark-nc
Copy link
Author

mark-nc commented Oct 22, 2019

This might be helpful to find these issues during dev/test time.
microsoft/TypeScript#19183 (comment)

starpit added a commit that referenced this issue Oct 23, 2019
@starpit
fix(packages/core): eliminate repl/exec -> spawn-electron import path
69a751c 
this should resolve an issue with spawn-electron's dependence on electron-context-menu, which has a dependence on cli-truncate that (with v2.0.0 of cli-truncate) is no longer compatible with edge.

Fixes #3014
starpit added a commit that referenced this issue Oct 23, 2019
@starpit
fix(packages/core): remove electron-context-menu dependence
65ed0f9 
also electron-squirrel-starutp
Fixes #3064

the former is causing problems with Edge
Fixes #3014
@starpit starpit reopened this Oct 24, 2019
@starpit starpit mentioned this issue Oct 24, 2019
Closed
@starpit
Copy link
Contributor

starpit commented Oct 24, 2019

seems good now. we should figure out how to lock this down.

@starpit starpit closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(packages/core): eliminate repl/exec -> spawn-electron import path starpit/kui
3 participants
@starpit @showeimer @mark-nc