Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide search capability on pod details Logs tab #5570

Closed
mark-nc opened this issue Sep 8, 2020 · 9 comments · Fixed by #7493
Closed

Provide search capability on pod details Logs tab #5570

mark-nc opened this issue Sep 8, 2020 · 9 comments · Fixed by #7493

Comments

@mark-nc
Copy link

mark-nc commented Sep 8, 2020

Today when clicking on a pod to get the pod details sidecar, the Logs tab will show either the streaming logs or not (if the user disables streaming). While this is useful, if there is a lot of log output, it may be hard to locate specific log statements the user cares about.

If using a normal text based terminal window, a user might run a logs command piped through grep someRegularExpression. Typing such a command in a Kui session opens up the pod details sidecar to the Logs tab, but that results in an error that grep does not understand the --tail parameter. This is not surprising as the Logs tab is not designed to work with piped commands. The user task, however, is a desire to search/filter log output to find something specific. It would be useful for the Logs tab to support some type of search feature where the user could enter a search string and then have the Logs tab filter the output to show the matches (and then be able to clear the search).

Some UX design work would be needed to have this follow similar other search patterns, but the feature would be useful.

@berenss
Copy link

berenss commented Sep 8, 2020

adding a 'filter' field to the streaming log feature, would be a very nice capability for an Ops/SRE

image

@starpit
Copy link
Contributor

starpit commented Sep 8, 2020

nice, thanks for the great ideas!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2021
@mark-nc
Copy link
Author

mark-nc commented Mar 24, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2021
@starpit
Copy link
Contributor

starpit commented May 28, 2021

Thanks for the issue, sorry for the delay here.

Is the request for find/highlight text? Or is it for filtering log lines (i.e. on a line-by-line basis) based on whether a given line contains a given pattern? I think the latter, but want to make sure. Thanks!

ref: https://www.npmjs.com/package/xterm-addon-search

@starpit
Copy link
Contributor

starpit commented May 28, 2021

We could also offer a Download button, to help with employing external tools.

@berenss
Copy link

berenss commented May 28, 2021

Yes it’s the latter, effectively a log tail with a grep. So having a filter box where I can I put the grep value and then the log follow will show me a reduced set of entries based on what is in the filter box.

We have another ctl being included for which a download capability would be very ideal! Not sure if our web browser based implementation can handle that thou.

@starpit
Copy link
Contributor

starpit commented May 28, 2021

@berenss thoughts?

ezgif com-gif-maker

@berenss
Copy link

berenss commented May 28, 2021

Love it! Thx 🚀

starpit added a commit to starpit/kui that referenced this issue May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants