Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown misparses certain links #6944

Closed
starpit opened this issue Feb 3, 2021 · 0 comments · Fixed by #6945
Closed

Markdown misparses certain links #6944

starpit opened this issue Feb 3, 2021 · 0 comments · Fixed by #6945
Assignees

Comments

@starpit
Copy link
Contributor

starpit commented Feb 3, 2021

This markdown source is misparsed:

https://google.com

with a strange href.

This bug is fixed by a more recent version of a transitive dependence of remark-gfm. We will need to re-generate our package-lock.json in order to pick up the fix.

Note: doing so will require us to bump our versions of webpack and webpack-cli, because it seems that they, yet again, have the same problem: they have some hidden transitive dependence that they refuse to pin, and so our package-lock.json may express a buggy combination of versions on the webpack side.

ref: remarkjs/remark-gfm#8

starpit added a commit to starpit/kui that referenced this issue Feb 3, 2021
As described in the issue, the fix requires re-generating our package-lock.json. Unfortunately, doing so also introduces a bug due to a webpack hidden dependence. So we need to bump the webpack and webpack-cli deps, as well.

Fixes kubernetes-sigs#6944
@starpit starpit self-assigned this Feb 3, 2021
starpit added a commit that referenced this issue Feb 3, 2021
As described in the issue, the fix requires re-generating our package-lock.json. Unfortunately, doing so also introduces a bug due to a webpack hidden dependence. So we need to bump the webpack and webpack-cli deps, as well.

Fixes #6944
starpit added a commit to starpit/kui that referenced this issue Feb 3, 2021
As described in the issue, the fix requires re-generating our package-lock.json. Unfortunately, doing so also introduces a bug due to a webpack hidden dependence. So we need to bump the webpack and webpack-cli deps, as well.

Fixes kubernetes-sigs#6944
starpit added a commit to starpit/kui that referenced this issue Feb 3, 2021
As described in the issue, the fix requires re-generating our package-lock.json. Unfortunately, doing so also introduces a bug due to a webpack hidden dependence. So we need to bump the webpack and webpack-cli deps, as well.

Fixes kubernetes-sigs#6944
starpit added a commit that referenced this issue Feb 4, 2021
As described in the issue, the fix requires re-generating our package-lock.json. Unfortunately, doing so also introduces a bug due to a webpack hidden dependence. So we need to bump the webpack and webpack-cli deps, as well.

Fixes #6944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant