Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find-in-page stripe doesn't have much contrast #7490

Closed
starpit opened this issue May 28, 2021 · 3 comments · Fixed by #7865 or #7883
Closed

find-in-page stripe doesn't have much contrast #7490

starpit opened this issue May 28, 2021 · 3 comments · Fixed by #7865 or #7883

Comments

@starpit
Copy link
Contributor

starpit commented May 28, 2021

It's hard to see it even.
@starpit
Copy link
Contributor Author

starpit commented May 28, 2021

the input element also doesn't span the entire width of the element. it seems like we're missing css rules somehow?

@starpit
Copy link
Contributor Author

starpit commented May 28, 2021

it looks like we aren't using the PatternFly Search input component? https://www.patternfly.org/v4/components/search-input

@starpit
Copy link
Contributor Author

starpit commented May 28, 2021

we could also finally support find next/previous

@mra-ruiz mra-ruiz mentioned this issue Aug 11, 2021
Merged
mra-ruiz added a commit to mra-ruiz/kui that referenced this issue Aug 11, 2021
@mra-ruiz
Search bar using patternfly and test file changes solving kubernetes-…
70dd027 
…sigs#7490
k8s-ci-robot pushed a commit that referenced this issue Aug 11, 2021
@mra-ruiz @k8s-ci-robot
Search bar using patternfly and test file changes solving #7490
29f5f43
mra-ruiz added a commit to mra-ruiz/kui that referenced this issue Aug 20, 2021
@mra-ruiz
Updated functionalities to search bar which solves kubernetes-sigs#7881…
314fd2a 
… and kubernetes-sigs#7490
mra-ruiz added a commit to mra-ruiz/kui that referenced this issue Aug 20, 2021
@mra-ruiz
Updated functionalities to search bar which solves kubernetes-sigs#7881…
980e165 
… and kubernetes-sigs#7490
@mra-ruiz mra-ruiz mentioned this issue Aug 20, 2021
Merged
mra-ruiz added a commit to mra-ruiz/kui that referenced this issue Aug 20, 2021
@mra-ruiz
Updated functionalities to search bar which solves kubernetes-sigs#7881…
204f970 
… and kubernetes-sigs#7490
k8s-ci-robot pushed a commit that referenced this issue Aug 20, 2021
@mra-ruiz @k8s-ci-robot
Updated functionalities to search bar which solves #7881 and #7490
e0502c3
starpit pushed a commit to starpit/kui that referenced this issue Aug 22, 2021
@mra-ruiz @starpit
Search bar using patternfly and test file changes solving kubernetes-…
a135f4e 
…sigs#7490
starpit pushed a commit to starpit/kui that referenced this issue Aug 22, 2021
@mra-ruiz @starpit
Updated functionalities to search bar which solves kubernetes-sigs#7881…
acde622 
… and kubernetes-sigs#7490
@starpit starpit mentioned this issue Aug 22, 2021
Merged
starpit pushed a commit that referenced this issue Aug 22, 2021
@mra-ruiz @starpit
Search bar using patternfly and test file changes solving #7490
86cc1c0
starpit pushed a commit that referenced this issue Aug 22, 2021
@mra-ruiz @starpit
Updated functionalities to search bar which solves #7881 and #7490
aeb7dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@starpit