Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show placeholder text to explain that ctrl+d closes split #7068

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Feb 23, 2021

part of #7060

ezgif com-gif-maker

Description of what you did:

My PR is a:

  • πŸ’₯ Breaking change
  • πŸ› Bug fix
  • πŸ’… Enhancement
  • πŸš€ New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #7068 (5bc9652) into master (57c4375) will decrease coverage by 17.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7068       +/-   ##
===========================================
- Coverage   60.07%   42.36%   -17.72%     
===========================================
  Files          86       81        -5     
  Lines        2705     2363      -342     
  Branches      678      618       -60     
===========================================
- Hits         1625     1001      -624     
- Misses        830     1162      +332     
+ Partials      250      200       -50     
Impacted Files Coverage Ξ”
packages/core/src/index.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/util/async.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/webapp/cancel.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/webapp/views/toolbar-text.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/repl/tab-completion.ts 20.00% <0.00%> (-60.00%) ⬇️
packages/core/src/webapp/block.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/core/src/core/symbol-table.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/core/src/core/usage-error.ts 3.31% <0.00%> (-45.59%) ⬇️
packages/core/src/webapp/util/time.ts 5.12% <0.00%> (-43.59%) ⬇️
packages/core/src/repl/split.ts 47.36% <0.00%> (-37.90%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 57c4375...5bc9652. Read the comment docs.

@starpit starpit merged commit 065990d into kubernetes-sigs:master Feb 23, 2021
@starpit starpit deleted the placeholder-ctrld branch February 23, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant