Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in electron mode, ctrl/cmd+w should always close kui tab #7494

Merged
merged 1 commit into from
May 28, 2021
Merged

fix: in electron mode, ctrl/cmd+w should always close kui tab #7494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/main/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const newSplit = () => tellRendererToExecute('split')
* tell the current window to close the current tab
*
*/
const closeTab = () => tellRendererToExecute('tab close')
const closeTab = () => tellRendererToExecute('tab close -A')

const isDarwin = process.platform === 'darwin'
const closeAccelerator = isDarwin ? 'Command+W' : 'Control+Shift+W'
Expand Down
5 changes: 0 additions & 5 deletions plugins/plugin-core-support/src/lib/cmds/quit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ const usage = (command: string) => ({

export default (commandTree: Registrar) => {
if (!inBrowser()) {
commandTree.listen('/quit', doQuit, {
usage: usage('quit')
})

// register a window close command handler
commandTree.listen('/window/close', () => {
const remote = require('electron').remote
Expand All @@ -44,7 +40,6 @@ export default (commandTree: Registrar) => {
})
}

// just for fun, make /exit a synonym for /quit
commandTree.listen('/exit', doQuit, {
usage: usage('exit')
})
Expand Down