Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins/plugin-kubectl): for now, send kubectl ... $(...) command… #8355

Merged
merged 1 commit into from
Dec 28, 2021
Merged

fix(plugins/plugin-kubectl): for now, send kubectl ... $(...) command… #8355

merged 1 commit into from
Dec 28, 2021

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Dec 28, 2021 •
edited
Loading

… lines to pty

At some point, we could get more sophisticated, and expand the $(...) subprocess executions, and still handle the rest in kui.

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@starpit
fix(plugins/plugin-kubectl): for now, send kubectl ... $(...) command…
7a4137e 
… lines to pty

At some point, we could get more sophisticated, and expand the $(...) subprocess executions, and still handle the rest in kui.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2021
@starpit starpit merged commit 374fa5b into kubernetes-sigs:master Dec 28, 2021
@starpit starpit deleted the pty-kube branch December 28, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-nc mark-nc Awaiting requested review from mark-nc

@myan9 myan9 Awaiting requested review from myan9

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starpit @k8s-ci-robot