11.1.4 #8546
Merged
11.1.4 #8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…would allow it We should just try the network request, and let the browser fail it for us, rather than trying to be smart, here.
…idebooks for pf4-light theme
…ave double margins especially for first-children. one for the expandable section (due to a `major-paragraph` css class) and one from the surrounding commentary card
…ebooks - allow content to be a bit wider - try to right-align expandable sections with wizard header
…of markdown For now, this moves the code block checkmark and timer to the top left, to avoid clipping.
…atter this also updates the knative guidebook to use that feature; and coincidentally adds a guidebook title to its metadata
Also updates the iter8 tutorial1.md to pull the content from iter8 Also adds support for renaming wizard steps in wizard topmatter
…r does not handle two links on one line bug in regexp
…t properly handle base path
…aphs bug in the css Also, add the box shadow margin hack to code blocks, to further the right-alignment work.
… `<kbd>` syntax `<mark>` uses the `==` syntax from pymdown https://facelessuser.github.io/pymdown-extensions/extensions/mark/ `<kbd>` uses the `++` syntax from pymdown https://facelessuser.github.io/pymdown-extensions/extensions/keys/
…ebar
so that the bottom-aligned content ("Toggle via <Esc>") always in view.
…s, Sidebar crashes on Escape
… of responses e.g. if the guidebook has 4 code blocks, and you are saving 3 or those 4, but the 4th has yet to be executed
This PR lays some groundwork that allows clients a more drop-in approach to provisioning guidebooks into a client. 1) Place the `.md` and `.json` files in your client's `notebooks/` directory 2) If you wish to have the guidebooks sidebar open by default, add `"showGuidebooksSidebar": true` to your config.d/client.json 3) If you wish Kui to operate in a mode where it shows a single guidebook at a time (rather that opening up Kui tabs for each opened guidebook), add `"singletonGuidebooks": true` to your config.d/client.json 4) (already the case before this PR): design your sidebar menu in config.d/notebooks.json 5) (new in this PR) if one of the leaf nodes in notebooks.json has `open: true`, then it will be autoplayed if you have also defined `singletonGuidebooks` and `showGuidebooksSidebar`
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[11.1.4 f99b23d] fix: fetchfile controller refuses any in-browser fetch, even if CORS would allow it
Date: Thu Jan 27 18:50:15 2022 -0500
3 files changed, 29 insertions(+), 18 deletions(-)
[11.1.4 9ef67ed] fix(plugins/plugin-patternfly4-themes): improve "warning" color in guidebooks for pf4-light theme
Date: Fri Jan 28 14:48:35 2022 -0500
2 files changed, 3 insertions(+), 1 deletion(-)
[11.1.4 cbe6bd3] fix(plugins/plugin-client-common): markdown expandable sections can have double margins
Date: Fri Jan 28 14:58:24 2022 -0500
1 file changed, 7 insertions(+)
[11.1.4 e43ba15] fix(plugins/plugin-client-common): a few small spacing tweaks to Guidebooks
Date: Sat Jan 29 11:22:38 2022 -0500
3 files changed, 6 insertions(+), 2 deletions(-)
[11.1.4 b4d5d27] chore(plugins/plugin-client-common): clean up markdown code block source
Date: Sat Jan 29 12:28:02 2022 -0500
4 files changed, 9 insertions(+), 9 deletions(-)
rename plugins/plugin-client-common/src/components/Content/Markdown/{codeblocks => components/code}/encoding.ts (96%)
rename plugins/plugin-client-common/src/components/Content/Markdown/components/{code.tsx => code/index.tsx} (93%)
rename plugins/plugin-client-common/src/components/Content/Markdown/{code-indexer.ts => components/code/rehype-code-indexer.ts} (98%)
[11.1.4 f286627] fix(plugins/plugin-client-common): another tweak for right-alignment of markdown
Date: Sat Jan 29 13:12:02 2022 -0500
2 files changed, 15 insertions(+), 8 deletions(-)
Auto-merging plugins/plugin-kubectl/notebooks/knative-getting-started.md
[11.1.4 720b189] feat: allow markdown guidebooks to define code block metadata in topmatter
Date: Sat Jan 29 14:12:47 2022 -0500
10 files changed, 176 insertions(+), 19 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/components/code/remark-codeblocks-topmatter.ts
create mode 100644 plugins/plugin-client-common/tests/data/code-block1-base.md
create mode 100644 plugins/plugin-client-common/tests/data/code-block1-validate-in-topmatter-via-snippet.md
create mode 100644 plugins/plugin-client-common/tests/data/code-block1-validate-in-topmatter.md
[11.1.4 f4e0a88] feat: when inlining guidebook snippets, rewrite relative image links
Date: Sat Jan 29 19:11:50 2022 -0500
7 files changed, 113 insertions(+), 166 deletions(-)
rewrite plugins/plugin-iter8/notebooks/tutorial1.md (81%)
[11.1.4 4c059d8] fix(plugins/plugin-client-common): snippet inliner image link rewriter does not handle two links on one line
Date: Sat Jan 29 19:54:15 2022 -0500
1 file changed, 5 insertions(+), 3 deletions(-)
[11.1.4 c9a0904] fix(plugins/plugin-client-common): recursive snippet inlining does not properly handle base path
Date: Sun Jan 30 13:09:03 2022 -0500
1 file changed, 10 insertions(+), 4 deletions(-)
[11.1.4 40ba36c] feat(plugins/plugin-client-common): support for "question" tips in markdown
Date: Sun Jan 30 13:34:41 2022 -0500
3 files changed, 51 insertions(+), 31 deletions(-)
[11.1.4 00cd830] fix(plugins/plugin-client-common): avoid pre-wrap in guidebook paragraphs
Date: Sun Jan 30 13:43:58 2022 -0500
1 file changed, 23 insertions(+), 17 deletions(-)
[11.1.4 84082da] feat(plugins/plugin-client-common): support for markdown
<mark>and<kbd>syntaxDate: Sun Jan 30 15:14:22 2022 -0500
12 files changed, 289 insertions(+), 2 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/remark-keys.ts
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/remark-mark.ts
create mode 100644 plugins/plugin-client-common/src/test/core/markdown/kbd.ts
create mode 100644 plugins/plugin-client-common/src/test/core/markdown/mark.ts
create mode 100644 plugins/plugin-client-common/tests/data/kbdtag1.md
create mode 100644 plugins/plugin-client-common/tests/data/kbdtag2.md
create mode 100644 plugins/plugin-client-common/tests/data/kbdtag3.md
create mode 100644 plugins/plugin-client-common/tests/data/marktag1.md
create mode 100644 plugins/plugin-client-common/tests/data/marktag2.md
create mode 100644 plugins/plugin-client-common/web/scss/components/Terminal/Keys.scss
[11.1.4 970a5c2] fix(plugins/plugin-client-common): markdown mark tags sometimes confused with tabbed
Date: Sun Jan 30 17:47:57 2022 -0500
5 files changed, 69 insertions(+), 8 deletions(-)
create mode 100644 plugins/plugin-client-common/tests/data/marktag3.md
create mode 100644 plugins/plugin-client-common/tests/data/marktag4.md
[11.1.4 aa722e2] doc: knative first-service and first-autoscale guidebooks
Date: Sun Jan 30 18:07:23 2022 -0500
4 files changed, 31 insertions(+), 1 deletion(-)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-first-autoscale.md
create mode 100644 plugins/plugin-kubectl/notebooks/knative-first-service.md
[11.1.4 9addb0a] fix(plugins/plugin-client-common): use inner scrolling of nav for sidebar
Date: Sun Jan 30 18:12:21 2022 -0500
1 file changed, 3 insertions(+)
[11.1.4 73ec8aa] fix(plugins/plugin-client-common): if client does not define notebooks, Sidebar crashes on Escape
Date: Sun Jan 30 18:46:55 2022 -0500
1 file changed, 7 insertions(+), 5 deletions(-)
[11.1.4 4b40f55] fix(Plugins/plugin-client-common): saving guidebook fails with subset of responses
Date: Mon Jan 31 10:30:10 2022 -0500
1 file changed, 3 insertions(+), 1 deletion(-)
[11.1.4 e073fed] feat:
<Kui/>component should automate more of guidebook mountingDate: Mon Jan 31 10:29:12 2022 -0500
13 files changed, 276 insertions(+), 67 deletions(-)
rename packages/core/src/api/{client.ts => Client.ts} (56%)
create mode 100644 packages/core/src/main/load.ts
create mode 100644 plugins/plugin-client-common/src/mount.ts