11.1.5 #8576
Merged
11.1.5 #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
also changes the displayed name of the tutorial1 iter8 guidebook
also, wizard descriptions that contain tips aren't processed properly
…litting guidebook
we are using a pretty bold color right now, which is distracting. mkdocs uses a much less saturated color for the headers/button part of expandable sections. this pr also reduces the border-radius on code blocks (6px -> 1px) this pr also restores the default patternfly sidebar width, which is a bit wider than what we had been forcing.
…rs not possible The code currently assumes that this combination does not happen.
This is probably mostly cosmetic in terms of our source code.
it doesn't really offer help, and now with the sidebar, we have a much richer way to access what the user might want, as opposed to a single fixed page Also avoid tab-focusing on the MastheadBrand. Also improve the consistency of focus/active outlining. We had some ancient rules that resulted in either no outline or outlines with different colors than the rest of the standard patternfly stylings.
…misplaced When using e.g. a left split
…ailing newlines This semantics is not specified in the pymdown docs: https://facelessuser.github.io/pymdown-extensions/extensions/snippets/ But seems to be the case. It probably makes sense to ignore trailing newlines. this lets you control the paragraph spacing in the parent document. Precisely for cases like using a snippet to bring in an svg icon, where you want the icon adjoined into a single paragraph with the icon link content
THis should clear up a false positive dependabot alert for ansi_up
… render second tip
Also includes a workaround for mis-rendered {draggable=false}
this is how mkdocs renders them. we have them currently as yellow.
…serve trailing whitespace
… markdown tables we had some old home-grown rules, probably from the carbon-components days?
In cases where the `<td/>` content is far narrower than the corresponding `<th/>` for that column, PatternFly (or is it Electron 13?) seems to favor ellipsis for the column header. This looks looks particularly bad if the td is quite narrow.
To make the titles more consistent.
This change is regarding the "snippet" (a.k.a. "markdown hash include") support. It enables us to do all of the inlining at webpack bundle build time, rather than doing it dynamically. 1) decreased load time when presenting a guidebook that employs snippets 2) allows running in a browser environment where the remote fetches would be blocked by CORS
… image links fail to load image
…s per paragraph we weren't handling more than one icon in a paragraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[11.1.5 1ede033] fix(plugins/plugin-kubectl): missing wizard title in knative guidebook
Date: Fri Jan 28 14:47:37 2022 -0500
1 file changed, 3 insertions(+), 2 deletions(-)
[11.1.5 10d1cd0a7] doc: remove old "welcome" iter8 guidebook
Date: Mon Jan 31 14:03:41 2022 -0500
3 files changed, 2 insertions(+), 57 deletions(-)
delete mode 100644 plugins/plugin-iter8/notebooks/welcome.md
[11.1.5 29c1d7086] feat(plugins/plugin-client-common): add support for "inline/inline-end" tips
Date: Mon Jan 31 15:38:43 2022 -0500
6 files changed, 37 insertions(+), 4 deletions(-)
[11.1.5 0744d86bb] fix(plugins/plugin-client-common): mis-parsing of wizard headers
Date: Mon Jan 31 18:37:47 2022 -0500
4 files changed, 29 insertions(+), 5 deletions(-)
[11.1.5 b963faeff] fix(plugins/plugin-kubectl): Adding first draft of Knative Traffic Splitting guidebook
Author: Maria Camila Ruiz Cardenas Maria.ruiz.cardenas@ibm.com
Date: Mon Jan 31 17:30:24 2022 -0500
3 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-traffic-splitting.md
[11.1.5 dd84a1adc] fix(plugins/plugin-client-common): reduce saturation of tip headers
Date: Tue Feb 1 12:35:55 2022 -0500
4 files changed, 8 insertions(+), 10 deletions(-)
[11.1.5 beff6cb6f] fix(plugins/plugin-client-common): wizards with left splits and headers not possible
Date: Tue Feb 1 13:26:46 2022 -0500
1 file changed, 26 insertions(+), 13 deletions(-)
[11.1.5 5ed311b0f] fix(plugins/plugin-client-common): minor fix to avoid
float: undefinedDate: Tue Feb 1 13:25:36 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.5 552627046] fix(plugins/plugin-client-default): don't show ? icon in default client
Date: Tue Feb 1 12:34:05 2022 -0500
6 files changed, 7 insertions(+), 32 deletions(-)
[11.1.5 b0bb947da] fix(plugins/plugin-client-common): wizard description overlay can be misplaced
Date: Tue Feb 1 14:06:41 2022 -0500
1 file changed, 23 insertions(+), 4 deletions(-)
[11.1.5 a0e93c5e0] fix(plugins/plugin-client-common): when including snippets, ignore trailing newlines
Date: Tue Feb 1 14:26:01 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.5 c40cda7] doc: add left split about knative to knative guidebooks
Date: Tue Feb 1 13:35:51 2022 -0500
6 files changed, 69 insertions(+), 5 deletions(-)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-what-is-it-good-for.md
[11.1.5 74b316c] doc: add left split to iter8 tutorial1
Date: Tue Feb 1 15:20:44 2022 -0500
3 files changed, 28 insertions(+), 9 deletions(-)
create mode 100644 plugins/plugin-iter8/notebooks/iter8-what-is-it-good-for.md
[11.1.5 2927fc1] doc: update knative github link to avoid pointing to docs github
Date: Tue Feb 1 15:16:12 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.5 267ba27] chore: remove unused dependences in nested package.json
Date: Tue Feb 1 15:41:43 2022 -0500
1 file changed, 1 insertion(+), 10 deletions(-)
[11.1.5 52681de] fix(plugins/plugin-kubectl): First draft of Knative Eventing guidebook
Author: Maria Camila Ruiz Cardenas Maria.ruiz.cardenas@ibm.com
Date: Tue Feb 1 14:05:17 2022 -0500
3 files changed, 25 insertions(+)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-introducing-eventing.md
[11.1.5 ded33b1] fix(plugins/plugin-kubectl): Eventing Components guidebook
Author: Maria Camila Ruiz Cardenas Maria.ruiz.cardenas@ibm.com
Date: Tue Feb 1 17:32:27 2022 -0500
3 files changed, 30 insertions(+)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-eventing-components.md
[11.1.5 a7b804f] fix(plugins/plugin-client-common): tip-after-tip in markdown fails to render second tip
Date: Tue Feb 1 17:48:21 2022 -0500
5 files changed, 36 insertions(+), 6 deletions(-)
rename plugins/plugin-client-common/src/test/core/{ => markdown}/tip.ts (87%)
create mode 100644 plugins/plugin-client-common/tests/data/tip-after-tip-in-tab.md
create mode 100644 plugins/plugin-client-common/tests/data/tip-after-tip.md
Auto-merging plugins/plugin-client-common/package.json
[11.1.5 29c6ca4] feat: initial support for material-... icons in markdown
Date: Tue Feb 1 19:35:38 2022 -0500
4 files changed, 80 insertions(+), 20 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/rehype-material-icons.ts
[11.1.5 b2719ef] doc: no need for a wizard in knative-introducing-eventing.md
Date: Tue Feb 1 19:36:21 2022 -0500
1 file changed, 1 insertion(+), 5 deletions(-)
[11.1.5 988525d] fix(plugins/plugin-client-common): markdown "note" tips should be blue
Date: Tue Feb 1 19:53:58 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.5 24ede51] fix(plugins/plugin-client-common): markdown material-icons do not preserve trailing whitespace
Date: Tue Feb 1 20:00:42 2022 -0500
1 file changed, 14 insertions(+), 7 deletions(-)
[11.1.5 4cc539c] fix(plugins/plugin-client-common): use standard patternfly tables for markdown tables
Date: Tue Feb 1 19:51:20 2022 -0500
4 files changed, 31 insertions(+), 17 deletions(-)
[11.1.5 3a6a500] fix(plugins/plugin-client-common): markdown tables can have odd ellipsis
Date: Wed Feb 2 09:35:57 2022 -0500
1 file changed, 9 insertions(+), 1 deletion(-)
[11.1.5 2dbce84] doc: add "Knative -" prefix to some of the knative guidebook titles
Date: Wed Feb 2 09:41:02 2022 -0500
3 files changed, 3 insertions(+), 3 deletions(-)
[11.1.5 177ed98] fix(plugins/plugin-kubectl):CloudEvents Player guidebook and typo fix
Author: Maria Camila Ruiz Cardenas Maria.ruiz.cardenas@ibm.com
Date: Wed Feb 2 12:05:47 2022 -0500
6 files changed, 34 insertions(+), 3 deletions(-)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-cloud-events-player.md
[11.1.5 da055a0] feat: inline markdown snippet inclusions at build time
Date: Wed Feb 2 13:05:23 2022 -0500
5 files changed, 203 insertions(+), 21 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/frontmatter-parser.tsx
create mode 100644 plugins/plugin-client-common/src/controller/snippets-inliner.ts
[11.1.5 efb7d35] fix(plugins/plugin-kubectl): Creating first Trigger guidebook
Author: Maria Camila Ruiz Cardenas Maria.ruiz.cardenas@ibm.com
Date: Wed Feb 2 13:18:39 2022 -0500
3 files changed, 16 insertions(+)
create mode 100644 plugins/plugin-kubectl/notebooks/knative-first-trigger.md
[11.1.5 04e78b8] fix(plugins/plugin-client-common): replay against files with relative image links fail to load image
Date: Wed Feb 2 15:15:21 2022 -0500
1 file changed, 6 insertions(+), 4 deletions(-)
Removing plugins/plugin-client-common/src/components/Content/Markdown/rehype-material-icons.ts
Auto-merging plugins/plugin-client-common/package.json
[11.1.5 46fe9c1] fix(plugins/plugin-client-common): fontawesome; fix for multiple icons per paragraph
Date: Wed Feb 2 14:47:41 2022 -0500
12 files changed, 214 insertions(+), 55 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/rehype-icons.ts
delete mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/rehype-material-icons.ts
create mode 100644 plugins/plugin-client-common/src/test/core/markdown/icons.ts
create mode 100644 plugins/plugin-client-common/tests/data/icons1.md
create mode 100644 plugins/plugin-client-common/tests/data/icons2.md
create mode 100644 plugins/plugin-client-common/tests/data/icons3.md
create mode 100644 plugins/plugin-client-common/tests/data/icons4.md
create mode 100644 plugins/plugin-client-common/tests/data/icons5.md
create mode 100644 plugins/plugin-client-common/tests/data/icons6.md