Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove electron/remote dep from core #9265

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Jan 28, 2023

This PR also removes some old unused deps from the core. Doing this identified a missing dep in plugin-bash-like (on properties-parser). This PR thus also adds that dep to plugin-bash-like, and adds the properties-parser types, and then shifts a require to an import.

Description of what you did:

Required Items

  • Your PR consists of a single commit (i.e. squash your commits)
  • Your commit and PR title starts with one of fix: | test: | chore: | doc:, to indicate the nature of the fix (see Conventional Commits)

Optional Items

  • 💥 This PR involves a breaking change. If so, include "BREAKING CHANGE: ...why..." in the commit and PR message.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2023
@k8s-ci-robot k8s-ci-robot requested review from mark-nc and myan9 January 28, 2023 19:51
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2023
This PR also removes some old unused deps from the core. Doing this identified a missing dep in plugin-bash-like (on properties-parser). This PR thus also adds that dep to plugin-bash-like, and adds the properties-parser types, and then shifts a require to an import.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2023
@starpit starpit merged commit cef337e into kubernetes-sigs:master Jan 28, 2023
@starpit starpit deleted the remote branch January 28, 2023 20:34
starpit added a commit to starpit/kui that referenced this pull request Jan 28, 2023
- We should be using the `webpackIgnore: true` magic comment, rather than the silly hack we had from kubernetes-sigs#9265
- kubernetes-sigs#9265 missed the second import of electron/remote
starpit added a commit to starpit/kui that referenced this pull request Jan 28, 2023
- We should be using the `webpackIgnore: true` magic comment, rather than the silly hack we had from kubernetes-sigs#9265
- kubernetes-sigs#9265 missed the second import of electron/remote
starpit added a commit that referenced this pull request Jan 28, 2023
- We should be using the `webpackIgnore: true` magic comment, rather than the silly hack we had from #9265
- #9265 missed the second import of electron/remote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants