-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add edit command option for editing name suffix
- Loading branch information
Showing
7 changed files
with
162 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
Copyright 2018 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package set | ||
|
||
import ( | ||
"errors" | ||
|
||
"github.com/spf13/cobra" | ||
"sigs.k8s.io/kustomize/pkg/commands/kustfile" | ||
"sigs.k8s.io/kustomize/pkg/fs" | ||
) | ||
|
||
type setNameSuffixOptions struct { | ||
suffix string | ||
} | ||
|
||
// newCmdSetNameSuffix sets the value of the nameSuffix field in the kustomization. | ||
func newCmdSetNameSuffix(fsys fs.FileSystem) *cobra.Command { | ||
var o setNameSuffixOptions | ||
|
||
cmd := &cobra.Command{ | ||
Use: "namesuffix", | ||
Short: "Sets the value of the nameSuffix field in the kustomization file.", | ||
Example: ` | ||
The command | ||
set namesuffix -acme | ||
will add the field "nameSuffix: -acme" to the kustomization file if it doesn't exist, | ||
and overwrite the value with "-acme" if the field does exist. | ||
`, | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
err := o.Validate(args) | ||
if err != nil { | ||
return err | ||
} | ||
err = o.Complete(cmd, args) | ||
if err != nil { | ||
return err | ||
} | ||
return o.RunSetNameSuffix(fsys) | ||
}, | ||
} | ||
return cmd | ||
} | ||
|
||
// Validate validates setNameSuffix command. | ||
func (o *setNameSuffixOptions) Validate(args []string) error { | ||
if len(args) != 1 { | ||
return errors.New("must specify exactly one suffix value") | ||
} | ||
// TODO: add further validation on the value. | ||
o.suffix = args[0] | ||
return nil | ||
} | ||
|
||
// Complete completes setNameSuffix command. | ||
func (o *setNameSuffixOptions) Complete(cmd *cobra.Command, args []string) error { | ||
return nil | ||
} | ||
|
||
// RunSetNameSuffix runs setNameSuffix command (does real work). | ||
func (o *setNameSuffixOptions) RunSetNameSuffix(fSys fs.FileSystem) error { | ||
mf, err := kustfile.NewKustomizationFile(fSys) | ||
if err != nil { | ||
return err | ||
} | ||
m, err := mf.Read() | ||
if err != nil { | ||
return err | ||
} | ||
m.NameSuffix = o.suffix | ||
return mf.Write(m) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
Copyright 2018 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package set | ||
|
||
import ( | ||
"strings" | ||
"testing" | ||
|
||
"sigs.k8s.io/kustomize/pkg/fs" | ||
) | ||
|
||
const ( | ||
goodSuffixValue = "-acme" | ||
) | ||
|
||
func TestSetNameSuffixHappyPath(t *testing.T) { | ||
fakeFS := fs.MakeFakeFS() | ||
fakeFS.WriteTestKustomization() | ||
|
||
cmd := newCmdSetNameSuffix(fakeFS) | ||
args := []string{goodSuffixValue} | ||
err := cmd.RunE(cmd, args) | ||
if err != nil { | ||
t.Errorf("unexpected cmd error: %v", err) | ||
} | ||
content, err := fakeFS.ReadTestKustomization() | ||
if err != nil { | ||
t.Errorf("unexpected read error: %v", err) | ||
} | ||
if !strings.Contains(string(content), goodSuffixValue) { | ||
t.Errorf("expected suffix value in kustomization file") | ||
} | ||
} | ||
|
||
func TestSetNameSuffixNoArgs(t *testing.T) { | ||
fakeFS := fs.MakeFakeFS() | ||
|
||
cmd := newCmdSetNameSuffix(fakeFS) | ||
err := cmd.Execute() | ||
if err == nil { | ||
t.Errorf("expected error: %v", err) | ||
} | ||
if err.Error() != "must specify exactly one suffix value" { | ||
t.Errorf("incorrect error: %v", err.Error()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters