refactor code to pass linting

cmd/gorepomod/internal/edit/editor.go

@@ -62,7 +62,7 @@ func (e *Editor) Pin(target misc.LaModule, oldV, newV semver.SemVer) error {
 		"-require=sigs.k8s.io/kustomize/"+string(target.ShortName())+"@"+newV.String(),
 	)
 	if err != nil {
-		return err
+		return fmt.Errorf("%w", err)
 	}
 	return e.run("tidy")
 }
@@ -81,7 +81,7 @@ func (e *Editor) UnPin(target misc.LaModule, oldV semver.SemVer) error {
 		"-replace="+r.String(),
 	)
 	if err != nil {
-		return err
+		return fmt.Errorf("%w", err)
 	}
 	return e.run("tidy")
 }

cmd/gorepomod/internal/git/runner.go

@@ -267,9 +267,12 @@ func (gr *Runner) FetchRemote(remote misc.TrackedRepo) error {
 	err := gr.runNoOut(noHarmDone, "fetch", string(remote))
 	if err != nil {
 		// If current repo is fork
-		return gr.runNoOut(noHarmDone, "fetch", string(remoteUpstream))
+		err = gr.runNoOut(noHarmDone, "fetch", string(remoteUpstream))
+		if err != nil {
+			return fmt.Errorf("%w", err)
+		}
 	}
-	return err
+	return fmt.Errorf("%w", err)
 }
 
 // MergeFromRemoteMain does a fast forward only merge with main branch.

cmd/gorepomod/internal/repo/dotgitdata.go

@@ -52,7 +52,6 @@ func (dg *DotGitData) AbsPath() string {
 //	~/gopath/src/sigs.k8s.io/kustomize
 //	~/gopath/src/github.com/monopole/gorepomod
 func NewDotGitDataFromPath(path string, localFlag bool) (*DotGitData, error) {
-
 	if !utils.DirExists(filepath.Join(path, dotGitFileName)) {
 		return nil, fmt.Errorf(
 			"%q doesn't have a %q file", path, dotGitFileName)
@@ -89,7 +88,6 @@ func NewDotGitDataFromPath(path string, localFlag bool) (*DotGitData, error) {
 			repoPath: path[index+len(srcHint):],
 		}, nil
 	}
-
 }
 
 // It's a factory factory.
@@ -187,17 +185,17 @@ func (dg *DotGitData) checkModulesLocal(modules []*protoModule) error {
 func getLocalPrefix(dgAbsPath string) string {
 	_, err := os.Stat(dgAbsPath + ".git")
 	if err != nil {
-		fmt.Errorf(".git directory does not exist int path %q", dgAbsPath)
+		_ = fmt.Errorf(".git directory does not exist int path %w", dgAbsPath)
 	}
 
 	out, err := exec.Command("git", "config", "--get", "remote.origin.url").Output()
 	if err != nil {
-		fmt.Errorf("failed extracting git information: %q", err.Error())
+		_ = fmt.Errorf("failed extracting git information: %w", err.Error())
 	}
 
 	localPrefix := utils.ParseGitRepositoryPath(string(out))
 	if len(localPrefix) == 0 {
-		fmt.Errorf("parsed git repository path is empty: %q", err.Error())
+		_ = fmt.Errorf("parsed git repository path is empty: %w", err.Error())
 	}
 	return localPrefix
 }

cmd/gorepomod/internal/repo/manager.go

@@ -84,7 +84,7 @@ func (mgr *Manager) List() error {
 	gr := git.NewQuiet(mgr.AbsPath(), false, false)
 	for _, module := range mgr.modules {
 		releaseBranch := fmt.Sprintf("release-%s", module.ShortName())
-		_, err := gr.GetLatestTag(string(releaseBranch))
+		_, err := gr.GetLatestTag(releaseBranch)
 		if err != nil {
 			fmt.Errorf("failed getting latest tags for %s", module)
 		}
@@ -134,7 +134,6 @@ func (mgr *Manager) Debug(_ misc.LaModule, doIt bool, localFlag bool) error {
 // * Each minor release gets its own branch.
 func (mgr *Manager) Release(
 	target misc.LaModule, bump semver.SvBump, doIt bool, localFlag bool) error {
-
 	if reps := target.GetDisallowedReplacements(
 		mgr.allowedReplacements); len(reps) > 0 {
 		return fmt.Errorf(

cmd/gorepomod/main.go

@@ -76,43 +76,48 @@ func actualMain() error {
 		v := args.Version()
 		// Update branch history
 		gr := git.NewQuiet(mgr.AbsPath(), args.DoIt(), false)
-		gr.FetchRemote(misc.TrackedRepo(gr.GetMainBranch()))
+		err = gr.FetchRemote(misc.TrackedRepo(gr.GetMainBranch()))
+		if err != nil {
+			return err
+		}
 
 		if v.IsZero() {
 			// Always use latest tag while does not removing manual usage capability
 			releaseBranch := fmt.Sprintf("release-%s", targetModule.ShortName())
 			fmt.Printf("new version not specified, fall back to latest version according to release branch: %s-*\n", releaseBranch)
-			latest, err := gr.GetLatestTag(string(releaseBranch))
+			latest, err := gr.GetLatestTag(releaseBranch)
 			if err != nil {
-				fmt.Errorf("cannot get latest tag for %s, falling back to local version %s", targetModule.ShortName(), targetModule.VersionLocal())
 				v = targetModule.VersionLocal()
-				return mgr.Pin(args.DoIt(), targetModule, v)
-
+				err = mgr.Pin(args.DoIt(), targetModule, v)
+				return fmt.Errorf("%w", err)
 			}
 			v, err = semver.Parse(latest)
 			if err != nil {
-				fmt.Errorf("failed to parse value for %s, falling back to local version %s", latest, targetModule.VersionLocal())
 				v = targetModule.VersionLocal()
-				return mgr.Pin(args.DoIt(), targetModule, v)
+				err = mgr.Pin(args.DoIt(), targetModule, v)
+				return fmt.Errorf("%w", err)
 			}
 		}
 
 		// If we can't find revision extracted from latest version specified on release branch
 		err = mgr.Pin(args.DoIt(), targetModule, v)
 		if err != nil {
-			fmt.Errorf("cannot determine latest version existence, retrying with local version %s", targetModule.VersionLocal())
 			v = targetModule.VersionLocal()
 			err = mgr.Pin(args.DoIt(), targetModule, v)
 		}
-		return err
+		return fmt.Errorf("%w", err)
 	case arguments.UnPin:
-		return mgr.UnPin(args.DoIt(), targetModule, conditionalModule)
+		err = mgr.UnPin(args.DoIt(), targetModule, conditionalModule)
+		return fmt.Errorf("%w", err)
 	case arguments.Release:
-		return mgr.Release(targetModule, args.Bump(), args.DoIt(), args.LocalFlag())
+		err = mgr.Release(targetModule, args.Bump(), args.DoIt(), args.LocalFlag())
+		return fmt.Errorf("%w", err)
 	case arguments.UnRelease:
-		return mgr.UnRelease(targetModule, args.DoIt(), args.LocalFlag())
+		err = mgr.UnRelease(targetModule, args.DoIt(), args.LocalFlag())
+		return fmt.Errorf("%w", err)
 	case arguments.Debug:
-		return mgr.Debug(targetModule, args.DoIt(), args.LocalFlag())
+		err = mgr.Debug(targetModule, args.DoIt(), args.LocalFlag())
+		return fmt.Errorf("%w", err)
 	default:
 		return fmt.Errorf("cannot handle cmd %v", args.GetCommand())
 	}