Skip to content

Commit

Permalink
add commentaries, change command order on presubmit-check
Browse files Browse the repository at this point in the history
  • Loading branch information
antoooks committed Sep 16, 2023
1 parent 532abf7 commit d78fe66
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
10 changes: 3 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,13 @@ verify-kustomize-repo: \
.PHONY: prow-presubmit-check
prow-presubmit-check: \
install-tools \
workspace-sync \
generate-kustomize-builtin-plugins \
test-unit-kustomize-plugins \
test-go-mod \
build-non-plugin-all \
test-examples-kustomize-against-HEAD \
test-examples-kustomize-against-latest-release \
workspace-sync \
generate-kustomize-builtin-plugins
test-examples-kustomize-against-latest-release

.PHONY: license
license: $(MYGOBIN)/addlicense
Expand Down Expand Up @@ -183,10 +183,6 @@ test-examples-kustomize-against-HEAD: $(MYGOBIN)/kustomize $(MYGOBIN)/mdrip
test-examples-kustomize-against-latest-release: $(MYGOBIN)/mdrip
./hack/testExamplesAgainstKustomize.sh v5@$(LATEST_RELEASE)

.PHONY: generate-kustomize-builtin-plugins
generate-kustomize-builtin-plugins:
$(MAKE) -f Makefile-plugin.mk

# Pushes dependencies in the go.work file back to go.mod files of each workspace module.
.PHONY: workspace-sync
workspace sync:
Expand Down
1 change: 1 addition & 0 deletions Makefile-plugins.mk
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ generate-kustomize-builtin-plugins: $(builtplugins)
cd ../../../; \
make no-diff \

# Check for diff, if diff is found, throw error code 1 (subject to change based on discussion)
.PHONY: no-diff
no-diff: $(builtplugins)
for file in $(abspath $(builtinplugins)); do \
Expand Down

0 comments on commit d78fe66

Please sign in to comment.