Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide simple way of sharing transformers configuration. #1509

Closed
jbrette opened this issue Sep 6, 2019 · 9 comments
Closed

Provide simple way of sharing transformers configuration. #1509

jbrette opened this issue Sep 6, 2019 · 9 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jbrette
Copy link
Contributor

jbrette commented Sep 6, 2019

During the investigation of the best option to allow a user simple adjust the default configuration of builtin transformers, the idea was proposed to leverage kustomize transformers in kustomization.yaml.

The example here is adding a label "env: canary" in one kustomize context, and "env: production" in the other.

The current issue is that the commonslabeltransformer.yaml is basically copy/pasted from the canary to production and only the "labels" section changes.

Full example is available here

production kustomization.yaml look so:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../base

transformers:
- ./kustomizeconfig/imagetransformer.yaml
- ./kustomizeconfig/namesuffixtransformer.yaml
- ./kustomizeconfig/commonlabelstransformer.yaml
- ./kustomizeconfig/patchstrategicmergetransformer.yaml

The commonlabelstransformer.yaml for the production environment looks this way.

apiVersion: builtin
kind: LabelTransformer
metadata:
  name: labeltransformer
labels:
  env: production
fieldSpecs:
- path: metadata/labels
  create: true
  kind: Service
- path: spec/selector
  create: true
  kind: Service
- path: metadata/labels
  create: true
  kind: Deployment
- path: spec/selector/matchLabels
  create: true
  kind: Deployment
- path: spec/template/metadata/labels
  create: true
  kind: Deployment

On the canary side:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- ../base

transformers:
- ./kustomizeconfig/imagetransformer.yaml
- ./kustomizeconfig/namesuffixtransformer.yaml
- ./kustomizeconfig/commonlabelstransformer.yaml
- ./kustomizeconfig/patchstrategicmergetransformer.yaml
apiVersion: builtin
kind: LabelTransformer
metadata:
  name: labeltransformer
labels:
  env: canary
fieldSpecs:
- path: metadata/labels
  create: true
  kind: Service
- path: spec/selector
  create: true
  kind: Service
- path: metadata/labels
  create: true
  kind: Deployment
- path: spec/selector/matchLabels
  create: true
  kind: Deployment
- path: spec/template/metadata/labels
  create: true
  kind: Deployment
@jbrette
Copy link
Contributor Author

jbrette commented Sep 6, 2019

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 4, 2020
@cscetbon
Copy link

@jbrette Exactly the issue I'm facing. Any progress on that somehow ? I tried to patch the transformer loaded from the base but I got #2055 (comment)

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chancez
Copy link
Contributor

chancez commented May 20, 2020

/reopen

This is something I've struggled with as well. I'd love if there was an env var for global configurations to tell kustomize how to interpret various kinds of resources.

@k8s-ci-robot
Copy link
Contributor

@chancez: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

This is something I've struggled with as well. I'd love if there was an env var for global configurations to tell kustomize how to interpret various kinds of resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratikzingade
Copy link

I have the exact same issue, was anyone able to solve this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants