-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Annotation Generator Options in Go Plugins #2380
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey All! I maintain a kustomize Go Plugin for SOPS encoded resources, called KSOPS, and one point of confusion/feature request I kept receiving was matching the behavior annotations supported implicitly by exec plugins. I ended up adding the same implicit support for these annotations by copying the
UpdateResourceOptions
code from the exec plugin.Is there a reason that exec plugins support this behavior out-of-the-box but Go plugins require explicit calls to
ResmapFactory().FromConfigMapArgs
orResmapFactory().FromSecretArgs
? Or to support annotations, copying theUpdateResourceOptions
as I didDoes it make sense to make
UpdateResourceOptions
a public plugin helper? Or support annotations implicitly for all Go plugins?Thanks for the input! Happy to contribute if this makes sense.
The text was updated successfully, but these errors were encountered: