Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Annotation Generator Options in Go Plugins #2380

Closed
devstein opened this issue Apr 16, 2020 · 4 comments
Closed

Support for Annotation Generator Options in Go Plugins #2380

devstein opened this issue Apr 16, 2020 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@devstein
Copy link
Contributor

Hey All! I maintain a kustomize Go Plugin for SOPS encoded resources, called KSOPS, and one point of confusion/feature request I kept receiving was matching the behavior annotations supported implicitly by exec plugins. I ended up adding the same implicit support for these annotations by copying the UpdateResourceOptions code from the exec plugin.

  1. Is there a reason that exec plugins support this behavior out-of-the-box but Go plugins require explicit calls to ResmapFactory().FromConfigMapArgs or ResmapFactory().FromSecretArgs? Or to support annotations, copying the UpdateResourceOptions as I did

  2. Does it make sense to make UpdateResourceOptions a public plugin helper? Or support annotations implicitly for all Go plugins?

Thanks for the input! Happy to contribute if this makes sense.

@devstein devstein changed the title Support for Annotation Generator Option in Go Plugins Support for Annotation Generator Options in Go Plugins Apr 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants