-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ImageTagTransformer legacy filter #5325
Comments
This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If someone wants this to move forward more quickly, you can start by taking a look at the blocking issue #4404. It is currently assigned to someone, but AFAIK they haven't started it yet and probably won't get to it for a little bit. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The
ImageTagTransformer
backing the Kustomizeimages
field is currently backed by 2 filters. We should deprecate thelegacy filter
. #4814 motivated this issue.I've noticed the following differences between the non-legacy and legacy filters. The deprecation assignee should investigate the two more thoroughly to ensure that the legacy filter deprecation doesn't have unintended consequences.
containers
andinitContainers
regardless of field path. Users can workaround this by specifyingFieldSpecs
for the non-legacy filter.images
ortransformers
field. The non-legacy requires users to pass inFieldSpecs
when invoked via thetransformers
field.As a result of the subpar UX in the 2nd bullet, #4404 blocks the legacy filter's deprecation.
The text was updated successfully, but these errors were encountered: