configMapGenerator: cannot merge or replace from components

[sgurdiel]

What happened?

Build fails

What did you expect to happen?

Build succeeds and configMap in overlay is merged with component configMap

How can we reproduce it (as minimally and precisely as possible)?

# components/co1/kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

configMapGenerator:
- name: configmap-name
  namespace: default
  literals:
  - hello=world

# overlays/o1/kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

components:
- ../../components/co1

configMapGenerator:
- name: configmap-name
  namespace: default
  behavior: merge
  literals:
  - hello=planet

kustomize build overlays/o1

Expected output

apiVersion: v1
data:
  hello: planet
kind: ConfigMap
metadata:
  name: configmap-name-m52bmf6b5t
  namespace: default

Actual output

Error: merging from generator &{0xc000390270 <nil>}: id resid.ResId{Gvk:resid.Gvk{Group:"", Version:"v1", Kind:"ConfigMap", isClusterScoped:false}, Name:"configmap-name", Namespace:"default"} does not exist; cannot merge or replace

Kustomize version

5.6.0, 5.5.0

Operating system

Linux

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sgurdiel]

In case this might help troubleshoot...

Replacing the behavior from merge to create in overlays/o1/kustomization.yml produces this output:

Error: merging from generator &{0xc0002b5520 <nil>}: id resid.ResId{Gvk:resid.Gvk{Group:"", Version:"v1", Kind:"ConfigMap", isClusterScoped:false}, Name:"configmap-name", Namespace:"default"} exists; behavior must be merge or replace

[adoramshoval]

Hi, can I work on this?

[sda399]

Hi

components are expected to execute after reading resources and adding generators ,before applying transformers and validation

Your generator is running before processing the component. You cannot merge in non existing CM

[sgurdiel]

Use case: Allowing overlays override (merge) configMaps created by reusable pieces of configuration logic (components).

Example: A database component that creates a configMap with database configuration settings and 2 different environments defined as overlays that include this component but require distinct database configuration setting.

This stopped working with v5 major release and I do not recall this being announced as an intended breaking change.

[sda399]

v5.1.0 released 2 years ago, the change is documented in the release notes

processing order is not so obvious topic, I guess.

anyway, for your use case, you still can patch your configmap in your overlays

#! /bin/sh

R=root
[ ! -d $R ] || rm -r $R
mk() { mkdir -p ${1%/*}  && echo "$2" >$1 ; }

mk $R/components/co1/kustomization.yaml '
# components/co1/kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

configMapGenerator:
- name: configmap-name
  namespace: default
  literals:
  - hello=world
'
mk $R/overlays/o1/kustomization.yaml '
# overlays/o1/kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

components:
- ../../components/co1

patches:
- patch: |-
    apiVersion: v1
    kind: ConfigMap
    metadata:
      name: configmap-name
      namespace: default
    data:
      hello: planet
'

#---
cat <<EOF > expected.yaml
apiVersion: v1
data:
  hello: planet
kind: ConfigMap
metadata:
  name: configmap-name-m52bmf6b5t
  namespace: default
EOF
#---
kustomize build --stack-trace $R/overlays/o1/ > result.yaml
printf "%-64s%s\n" expected.yaml result.yaml
printf "%130s\n" " " | tr ' ' '-'
diff -W130 -y expected.yaml result.yaml

[Elegant996]

@adoramshoval Confirming the same issue. Will use snippets here but the issue should be clear:

base.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

configMapGenerator:
  - name: app-env
    envs:
      - .env

extras.yaml:

apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

configMapGenerator:
  - name: app-env
    behavior: merge
    envs:
      - .env

We get an error: Error: merging from generator &{0xc00046a340 <nil>}: id resid.ResId{Gvk:resid.Gvk{Group:"", Version:"v1", Kind:"ConfigMap", isClusterScoped:false}, Name:"app-env", Namespace:""} does not exist; cannot merge or replace

Okay, let's try that again without the behavior:

extras.yaml:

apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

configMapGenerator:
  - name: app-env
    # behavior: merge
    envs:
      - .env

Now we get a complete contradiction: Error: accumulating components: accumulateDirectory: "recursed accumulation of path '/home/runner/work/test/failing-components': merging from generator &{0xc00038d860 <nil>}: id resid.ResId{Gvk:resid.Gvk{Group:\"\", Version:\"v1\", Kind:\"ConfigMap\", isClusterScoped:false}, Name:\"app-env\", Namespace:\"\"} exists; behavior must be merge or replace"

No matter how you slice it, there's an issue here. You can't state the configmap doesn't exist then complain that it does.

[adoramshoval]

Hi all!
Thank you for letting me work on this issue.
I am new to the code base so it might take me some time 🤗

[adoramshoval]

/assign

[adoramshoval]

It seems like everything lies within the kusttarget.go file which controls the accumalation of resources.
After some digging, it does not seem like there is a problem, it looks like everything does what is supposed to do.
(TLDR at the end)

For merge or replace behavior, the chain of events goes as follows:

1. The KustTarget.accumulateTarget is executed:
   

   kustomize/api/internal/target/kusttarget.go

   Lines 197 to 199 in 7c04cbb

   	// ra should be empty when this KustTarget is a Kustomization, or the ra of the parent if this KustTarget is a Component
   	// (or empty if the Component does not have a parent).
   	func (kt *KustTarget) accumulateTarget(ra *accumulator.ResAccumulator) (

2. Then, runGenerators is executed:
   

   kustomize/api/internal/target/kusttarget.go

   Lines 225 to 228 in 7c04cbb

   	err = kt.runGenerators(ra)
   	if err != nil {
   	return nil, err
   	}

3. Which, at the end, goes through each generated resource map and attempts to make the resource accumulator absorb it:
   

   kustomize/api/internal/target/kusttarget.go

   Lines 291 to 294 in 7c04cbb

   	err = ra.AbsorbAll(resMap)
   	if err != nil {
   	return errors.WrapPrefixf(err, "merging from generator %v", g)
   	}

4. The absorbtion is done by going through each resource in the absorbed resource map and attempting to append, replace or merge the resource, which correlates to the resource's chosen behavior - create, merge or replace:
   

   kustomize/api/resmap/reswrangler.go

   Line 560 in 7c04cbb

   func (m *resWrangler) appendReplaceOrMerge(res *resource.Resource) error {

As can be seen in the appendReplaceOrMerge function, if no older version of the resource you are currently running the function on exists in the main resource map, you can't use merge or replace behaviors, which is expected, as there is no resource to merge with nor to be replaced.

kustomize/api/resmap/reswrangler.go

Lines 562 to 568 in 7c04cbb

	matches := m.GetMatchingResourcesByAnyId(id.Equals)
	switch len(matches) {
	case 0:
	switch res.Behavior() {
	case types.BehaviorMerge, types.BehaviorReplace:
	return fmt.Errorf(
	"id %#v does not exist; cannot merge or replace", id)

In the case of create behavior, the runGenerators mentioned above will run correctly and create the ConfigMap as expected, the issue will come down when the components are processed, which is right after the runGenerators, here:

kustomize/api/internal/target/kusttarget.go

Lines 230 to 235 in 7c04cbb

	// components are expected to execute after reading resources and adding generators ,before applying transformers and validation.
	// https://github.com/kubernetes-sigs/kustomize/pull/5170#discussion_r1212101287
	ra, err = kt.accumulateComponents(ra, kt.kustomization.Components)
	if err != nil {
	return nil, errors.WrapPrefixf(err, "accumulating components")
	}

1. This function in turn create a KustTarget for each component directory and attempts to accumulate that directory, the same way the original kustomization directory was accumulated:
   

   kustomize/api/internal/target/kusttarget.go

   Lines 472 to 483 in 7c04cbb

   	origin := kt.origin.Copy()
   	if kt.origin != nil {
   	kt.origin = kt.origin.Append(path)
   	ra, errD = kt.accumulateDirectory(ra, ldr, true)
   	// after we are done recursing through the directory, reset the origin
   	kt.origin = &origin
   	} else {
   	ra, errD = kt.accumulateDirectory(ra, ldr, true)
   	}
   	if errD != nil {
   	return nil, fmt.Errorf("accumulateDirectory: %q", errD)
   	}

2. There, accumulateTarget is executed for the component directory, which in turn executes the runGenerators again:
   

   kustomize/api/internal/target/kusttarget.go

   Lines 519 to 522 in 7c04cbb

   	if isComponent {
   	// Components don't create a new accumulator: the kustomization directives are added to the current accumulator
   	subRa, err = subKt.accumulateTarget(ra)
   	ra = accumulator.MakeEmptyAccumulator()

3. Now, when the runGenerators function is executed, there is already a resource which has the same ID as the resource being generated in the component, which means the following case will be entered:
   

   kustomize/api/resmap/reswrangler.go

   Lines 573 to 601 in 7c04cbb

   	case 1:
   	old := matches[0]
   	if old == nil {
   	return fmt.Errorf("id lookup failure")
   	}
   	index := m.indexOfResource(old)
   	if index < 0 {
   	return fmt.Errorf("indexing problem")
   	}
   	switch res.Behavior() {
   	case types.BehaviorReplace:
   	res.CopyMergeMetaDataFieldsFrom(old)
   	case types.BehaviorMerge:
   	// ensure the origin annotation doesn't get overwritten
   	orig, err := old.GetOrigin()
   	if err != nil {
   	return err
   	}
   	res.CopyMergeMetaDataFieldsFrom(old)
   	res.MergeDataMapFrom(old)
   	res.MergeBinaryDataMapFrom(old)
   	if orig != nil {
   	res.SetOrigin(orig)
   	}
   	default:
   	return fmt.Errorf(
   	"id %#v exists; behavior must be merge or replace", id)
   	}

kustomize/api/resource/resource.go

Lines 397 to 403 in 7c04cbb

	func (r *Resource) Behavior() types.GenerationBehavior {
	annotations := r.GetAnnotations()
	if v, ok := annotations[utils.BuildAnnotationsGenBehavior]; ok {
	return types.NewGenerationBehavior(v)
	}
	return types.NewGenerationBehavior("")
	}

4. Here, since no behavior was specified in the component itself, an empty behaior be will returned, which will enter the default case and raise the error you are getting.

• TLDR for merge or replace behaviors inside the kustomization.yaml configMapGenerator: This is the correct behavior, you are unable to merge or replace the generated config map with non existing config map. The generator inside the kustomization.yaml file is run before the component one, which means there are no resources to merge or replace with.
• TLDR for create behavior inside the kustomization.yaml configMapGenerator: By specifying a behavior, merge or replace at the component configMapGenerator you could avoid the error you are getting, otherwise, this seems like the correct behavior.

Continuation:

What we could take from this is making the raised error more understandable to the user, as from the user's POV the resource does not exist, which is confusing. Maybe we could add a case for create behavior at the component level, which will raise this error, and another case for an unspecified behavior which will have an understandable reasoning for the failure. I will create a PR for that.

Let me know if I missed anything here, or if I am completely wrong.

[adoramshoval]

@sgurdiel , @Elegant996 , @sda399 Was that a sufficient answer?
Can we close this issue?