Introduce envs field. #1041
Merged
Introduce envs field. #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
monopole
requested review from
sethpollack
and removed request for
justinsb and
Liujingfang1
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In secret / configmap generation, kustomize 2.0.3 accepts lists of k=v literals, and lists of files where the file contents is the value, but only one instance of a so called env file (where the contents are k=v pairs, one per line). This singleton is an odd special case, and makes it hard to mix k=v pairs from multiple sources, e.g. from a devops team and a UX team (one must create then merge whole ConfigMaps to accomplish it).
This PR adds the field
EnvSources(yaml:envs) to kustomization.yaml, accepting a list, and deprecates the singular formEnvSource(yaml:env). Users need do nothing, the old field is silently merged into the new. Anyone runningkustomize fixoreditwill get the new field format replacing the old.This will be new behavior in kustomize 2.1