Skip kustomize transformers for paths #1491
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
|
/assign @Liujingfang1 |
|
@jbrette I don't think we agree on which solution kustomize should go with. This is a very important feature. Let's think about it carefully before putting any implementation for it. Would you like open an KEP for this? List and compare different solutions. Then we can bring it into discussion in a SIG-CLI meeting and have people agree on the best solution. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jbrette The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jbrette
force-pushed
the
fsskip
branch
2 times, most recently
from
adf6ddd
to
94ead03
Compare
|
@Liujingfang1 @richardmarshall @sethp-nr I will open the KEP. |
k8s-ci-robot
added
size/XXL
jbrette
force-pushed
the
fsskip
branch
2 times, most recently
from
4cd6cb7
to
d856191
Compare
|
@monopole @Liujingfang1 @richardmarshall @sethp-nr As agreed, here is the corresponding KEP |
jbrette
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Liujingfang1
added
the
do-not-merge/hold
jbrette
force-pushed
the
fsskip
branch
3 times, most recently
from
e8d0435
to
6118090
Compare
jbrette
force-pushed
the
fsskip
branch
4 times, most recently
from
64bb752
to
c1cf89c
Compare
jbrette
force-pushed
the
fsskip
branch
2 times, most recently
from
9fd7543
to
a4f05bf
Compare
Add "add", "replace" and "remove" behavior to transformerconfig.
Introduces a new config field, `namePrefixSuffixSkip`, that takes a list of gvk arguments. For example: ``` namePrefixSuffixSkip: - apiVersion: storage.k8s.io/v1 kind: StorageClass ``` For any matching group/version and kind, kustomize will preserve the original resource name even if `namePrefix` and `nameSuffix` are defined.
For types that give special meaning to an empty selector, having create=true overwrites the implicit default labels
|
@jbrette why close this PR ? |
|
@nlamirault I can't recollect a single "Feature PR" merged to kustomize even when we took the time to open KEP in kubernetes/sig-cli, it was addressing multiple projects needs and issues. We had quite a lot of "Bug Fixes PR" merged, but no feature one. So, like the autovar feature #1217 , the inlining feature #1208 , the diamond import #1316 , the SMP for CRD feature, this feature PR was on course to rot. Hence it did not make any sense trying to keep it small to ease the reviewing. It was causing us internal merge issues with additional improvements and bug fixes waiting in line behind that PR. Since our project needs those features, we will unfortunately have to maintain them until something equivalent is officially integrated Kustomize. Meanwhile in order to reduce our workload, we squashed all the commits and divided by two the numbers of branches we have to maintain. The code for this particular PR has been merged with actual bug fixes here: transformers branch. We pull all those features together and the associated additional regressions tests in this branch. |
This PR attempts to fix: Skip kustomize transformers for paths #896
It leverage the work done in #1485
It aims to address the following issue:
Make cluster level kind configurable #617
Do not add namespace to cluster scoped CRDs #552
Skipping nameprefix for some resource kind #519
Adding labels only to metadata.labels #330
Skip adding labels to certain paths #519
Unable to disable commonLabels injection using transformer config: Error: conflicting fieldspecs #817