Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git commit hash ignored #2537

Merged
merged 2 commits into from
May 27, 2020

Conversation

Shell32-Natsu
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Shell32-Natsu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2020
@Shell32-Natsu
Copy link
Contributor Author

/assign @Liujingfang1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shell32-Natsu
To complete the pull request process, please assign liujingfang1
You can assign the PR to them by writing /assign @liujingfang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@monopole
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
@monopole monopole self-requested a review May 27, 2020 20:05
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code has been pulled in various directions. #857 (which added --depth 1) was a performance enhancement. An old use of go-getter was removed because it exploded the vendor directory in used at the time with excessive deps. We'll try this and see what happens.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@monopole monopole merged commit dd4aafe into kubernetes-sigs:master May 27, 2020
@Shell32-Natsu Shell32-Natsu deleted the fix-clone-hash branch May 27, 2020 20:25
@JTarasovic
Copy link

built kustomize locally and tested against a couple of repos with kustomization.yamls

  • commit hash: appears to use correct ref (no diff from our pegged version w/ v0.5.1)
  • branch ref: looks to pull correct branch
  • no ref: pulls default branch

ribbybibby added a commit to utilitywarehouse/kube-applier that referenced this pull request Jun 3, 2020
This includes a fix for a pretty big regression in 3.5.5 where using commit hash
as a ref when pulling remote files didn't work:
- kubernetes-sigs/kustomize#2537
ribbybibby added a commit to utilitywarehouse/kube-applier that referenced this pull request Jun 3, 2020
This includes a fix for a pretty big regression in 3.5.5 where using commit hash
as a ref when pulling remote files didn't work:
- kubernetes-sigs/kustomize#2537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants