-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git commit hash ignored #2537
Fix git commit hash ignored #2537
Conversation
Hi @Shell32-Natsu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Liujingfang1 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shell32-Natsu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code has been pulled in various directions. #857 (which added --depth 1
) was a performance enhancement. An old use of go-getter was removed because it exploded the vendor directory in used at the time with excessive deps. We'll try this and see what happens.
/lgtm
built
|
This includes a fix for a pretty big regression in 3.5.5 where using commit hash as a ref when pulling remote files didn't work: - kubernetes-sigs/kustomize#2537
This includes a fix for a pretty big regression in 3.5.5 where using commit hash as a ref when pulling remote files didn't work: - kubernetes-sigs/kustomize#2537
#2444
#2494