Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change to live commands retrieval #3025

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Small change to live commands retrieval #3025

merged 1 commit into from
Sep 22, 2020

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Sep 21, 2020

  • Small change to command to retrieve live cobra commands. Allows changes to Runner commands.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seans3
To complete the pull request process, please assign phanimarupaka
You can assign the PR to them by writing /assign @phanimarupaka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2020
@seans3
Copy link
Contributor Author

seans3 commented Sep 22, 2020

/assign @monopole

@monopole
Copy link
Contributor

/lgtm

@monopole monopole merged commit e3cf898 into kubernetes-sigs:master Sep 22, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@monopole monopole

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seans3 @k8s-ci-robot @monopole