Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency from cmd/config on cli-utils #3037

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

mortent
Copy link
Member

@mortent mortent commented Sep 24, 2020

This removes the dependency from cmd/config on cli-utils. It is not used at the moment. I can update the PR to delete the file instead of commenting it out if that is preferable.

If we decide to put this back in, we should have the kustomize/kustomize module depend on cli-utils and not cmd/config. The current setup makes it hard for projects that depends on both modules to pull in changes from cli-utils.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2020
@mortent mortent requested review from seans3 and monopole September 24, 2020 05:04
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@mortent mortent removed the request for review from droot September 24, 2020 05:05
@monopole
Copy link
Contributor

Let's not check in commented code like this. Prefer to formulate a plan for clis to import live and cfg, then refactor things appropriately (presumably deleting this).

FWIW, I closed #2677 because we defined a sequence that works:
https://github.com/kubernetes-sigs/kustomize/tree/master/releasing#release-sequence.
Is that order the thing that's hard? It's annoying, but we're still on the hook to release 5 modules in a full kustomize release, unless we merge some of them.

@monopole
Copy link
Contributor

Meh, let's delete and not block on a plan right now. Still some questions to answer.

@mortent mortent force-pushed the RemoveDepOnCliUtils branch from d2ebf80 to db6c825 Compare September 24, 2020 18:16
@mortent
Copy link
Member Author

mortent commented Sep 24, 2020

@monopole Updated the PR to remove the file instead of commenting it out.

@monopole
Copy link
Contributor

/lgtm

@monopole monopole merged commit 3a59515 into kubernetes-sigs:master Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@mortent mortent deleted the RemoveDepOnCliUtils branch July 23, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants