Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests. #3274

Closed
wants to merge 1 commit into from
Closed

More tests. #3274

wants to merge 1 commit into from

Conversation

monopole
Copy link
Contributor

@monopole monopole commented Nov 25, 2020

To RNode add methods

Get/SetNamespace
Get/SetLabels
Get/SetAnnotations

These setters completely remove the field if the argument
is empty, rather than setting the field to an empty value,
mimicing apimachinery behavior.

The implementations in WNode are supposed to be thin, as they are temporary.
This means pushing logic down to RNode.

This is generally in service of #2915.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@monopole monopole force-pushed the moarTests branch 3 times, most recently from 0c7c62b to 860cd84 Compare November 25, 2020 14:29
@k8s-ci-robot
Copy link
Contributor

@monopole: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kustomize-presubmit-master 1be9b94 link /test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monopole monopole closed this Nov 25, 2020
@monopole monopole deleted the moarTests branch November 30, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants