Provide timeouts for all remote loads. #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
api/internal/git/cloner.go
Outdated
| if er = r.run("remote", "add", "origin", repoSpec.CloneSpec()); er != nil { | ||
| return er | ||
| } | ||
| { |
There was a problem hiding this comment.
confines the scope of ref. It's such a small method now i can remove it.
api/internal/git/cloner.go
Outdated
| } | ||
|
|
||
| return nil | ||
| r, er := newCmdRunner() |
There was a problem hiding this comment.
most errors in kustomize are using err. any reason for using er?
There was a problem hiding this comment.
keeping linelen under 80. changed back to err, but added linefeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds timeout with descriptive error messages for what ran out of time.
Before this, timeouts were only imposed by the example runner,
making the cause hard to determine.