Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Resource.refBy with annotations #4002

Merged
merged 1 commit into from
Jul 9, 2021
Merged

replace Resource.refBy with annotations #4002

merged 1 commit into from
Jul 9, 2021

Conversation

natasha41575
Copy link
Contributor

fixes #3976

@natasha41575 natasha41575 requested review from monopole and KnVerey June 17, 2021 00:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2021
@natasha41575 natasha41575 marked this pull request as draft June 17, 2021 00:48
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@natasha41575 natasha41575 marked this pull request as ready for review July 7, 2021 22:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2021
@natasha41575 natasha41575 removed the request for review from phanimarupaka July 7, 2021 22:23
KnVerey
KnVerey approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 259fcfc into kubernetes-sigs:master Jul 9, 2021
@rishabh625
Copy link

since this change adds config.kubernetes.io/refBy annotation , other annotations value is not getting replaced

@rishabh625
Copy link

/auto-cc

@rishabh625 rishabh625 mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey approved these changes

@monopole monopole Awaiting requested review from monopole

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Resource.refBy with annotations
4 participants
@natasha41575 @k8s-ci-robot @rishabh625 @KnVerey