-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition implementation prototype #4323
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
@KnVerey: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a fairly complete implementation of kubernetes/enhancements#2299. This PR is way too big to review; I'll open separate, more granular PRs that reference this one.
Besides the TODOs in this PR, work remaining to make Composition usable includes:
resources
field and invokable from the extensions fields. TheResourceGenerator
generator in this PR only handles files, not directories, and therefore not bases and has no tests. Ideally the new generator should be an extraction of the code driving the field, and the field should switch to using it. Package structure is a big challenge here, since the generator will need to be able to expand bases, which uses krusty, which is in the api modules, which imports plugins. I.e. it probably can't be built the same way we've built all the builtin generators historically. Convertresources
andcomponents
to be backed by a reusable generator #4402fieldSpecs
field defaults to empty instead of the usual defaults. That's a pretty big usability issue for Composition. Can we change that (are transformers with empty fieldSpecs conceptually valid?) or introduce a way of building on instead of overriding the defaults? Enable explicitly invoked transformers to use default fieldSpecs #4404fyi @jeremyrickard @natasha41575