Address nits on localize proposal and correct mistakes
#4668
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @annasong20. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
proposals/22-04-localize-command.md
Outdated
| </pre> | ||
|
|
||
| where the arguments are: | ||
|
|
||
| * `target`: a directory with a top-level kustomization file that kustomize will localize; can be a path to a local | ||
| directory or a url to a remote directory | ||
| * `newDir`: optional destination directory of the localized copy of `target`; if not specified, the destination is a | ||
| directory named `localized-{target}` in the same directory as `scope` | ||
| directory named `localized-{target}` in the working directory |
There was a problem hiding this comment.
This is a divergence from our previous discussions. I propose this change because there is no way to create newDir in the same directory as a remote scope. In such a case, I believe creating newDir in the working directory of the command line is the most intuitive alternative. We could specify different default newDir locations for local vs. remote scopes and create newDir next to local scopes, but this is more work for the user to remember.
There was a problem hiding this comment.
The working directory sounds like a reasonable default, but I didn't realize we intended to support situations where even the target itself is remote. If that's the case, I think we should clarify that in the arguments (e.g. "a directory" sounds local to me) and maybe add a user story for that.
There was a problem hiding this comment.
I think we should clarify that in the arguments (e.g. "a directory" sounds local to me)
Under target's description, after the semicolon, we mention "can be ... a url to a remote directory". Is this enough?
and maybe add a user story for that.
Sure! I'll add one.
annasong20
changed the title
localize proposal and correct mistakes
Remove scope, add ref, add user story
|
@annasong20: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Address Katrina's final feedback on and correct other mistakes in #4590