-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edit set image to parse both tag and digest #5234
fix edit set image to parse both tag and digest #5234
Conversation
|
Welcome @blackjid! |
Hi @blackjid. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @KnVerey @natasha41575 @koba1t |
/unassign @KnVerey @natasha41575 @koba1t |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
I added a few nit comments. Please check!
716a102
to
7b75259
Compare
@blackjid The intention of merging that PR was not to expose the APIs to the users that was being utilized just in api/ pkg. Since this PR only uses the helpers from Let me know if I'm missing anything else in the use of image pkg. If needed we can expose it again, but I would vote for not entirely exposing it, if we want to use just a helper method. |
26988e8
to
b8015ed
Compare
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
b8015ed
to
1a05794
Compare
@varshaprasad96 That sounds good.., I have made the changes... let me know if there is something missing, or some change needed... |
Do you prefer to use the new util to replace the direct call here also?? https://github.com/kubernetes-sigs/kustomize/blob/master/api/filters/imagetag/updater.go#L34 |
@varshaprasad96 can you take another look at this PR to check if your comments are addressed? /assign @varshaprasad96 |
😢 |
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackjid Really sorry for missing this PR. The changes look good to me.
I've kicked the CI to re-trigger the linter tests. Could you please address those. Once they pass this should be good to merge.
/lgtm
/approve
Looks like the CI is not being triggered. @blackjid could you please close and re-open and PR to see if this works. I don't have permissions to do it. |
@koba1t @natasha41575 could you please approve the workflow runs? Looks like I don't have permissions for it. |
1a05794
to
a85dfd4
Compare
@varshaprasad96 I've fixed the linter magic numbers issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Once the CI is triggered and run is successful, it would be added to the merge queue.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blackjid, FrenchBen, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref. #4713
Add support to pass both tag and digest to
edit set image command