Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --load-restrictor completion #5411

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add --load-restrictor completion #5411

merged 2 commits into from
Feb 1, 2024

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Oct 23, 2023

Everytime I use kustomize I need to lookup the string for the none restrictor.

Setting up completion for this flag to not lose time any more.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sylr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2023
charles-chenzz
charles-chenzz reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2023
@sylr sylr force-pushed the complete-load-restrictor branch from 82c617f to 7228a28 Compare October 28, 2023 10:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
charles-chenzz
charles-chenzz reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @natasha41575 @koba1t
/cc @stormqueen1990 (for another pass)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023
stormqueen1990
stormqueen1990 reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylr thanks for your contribution! There's a small issue with the cmd.RegisterFlagCompletionFunc statement because the error is not currently being handled, but other than that it LGTM.

kustomize/commands/build/flagloadrestrictor.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@sylr sylr force-pushed the complete-load-restrictor branch from 72dd179 to bf4892d Compare November 21, 2023 09:38
@sylr
Copy link
Contributor Author

sylr commented Nov 27, 2023

@stormqueen1990 could you approve the tests please ?

@natasha41575
Copy link
Contributor

I can do a review here for approval once the lint failures are passing

sylr added 2 commits December 6, 2023 10:34
@sylr
Add build --load-restrictor completion
e3031f3 
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@sylr
Add missing error handling for --load-restrictor completion
82bd395 
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@sylr sylr force-pushed the complete-load-restrictor branch from bf4892d to 82bd395 Compare December 6, 2023 09:38
stormqueen1990
stormqueen1990 reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
ncapps
ncapps reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ncapps ncapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this locally and verified the expected behavior. Thank you for the contribution!

/lgtm

@koba1t
Copy link
Member

koba1t commented Feb 1, 2024

@sylr

Thanks for your contribution!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 31b852c into kubernetes-sigs:master Feb 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-chenzz charles-chenzz charles-chenzz left review comments

@ncapps ncapps ncapps left review comments

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

@annasong20 annasong20 Awaiting requested review from annasong20

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@stormqueen1990 stormqueen1990

@ncapps ncapps

@natasha41575 natasha41575

@koba1t koba1t

@charles-chenzz charles-chenzz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Kustomize Core Usability Bugs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sylr @k8s-ci-robot @natasha41575 @koba1t @stormqueen1990 @ncapps @charles-chenzz