-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support namespace flag on edit remove secret/configmap #5454
fix: support namespace flag on edit remove secret/configmap #5454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving existing test names!
I have one minor question about potential additional test scenarios.
1e5464e
to
8dd9328
Compare
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix the 'edit remove secret'/'edit remove configmap' commands that were previously missing support to specifying a namespace.
8dd9328
to
228d22c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
edit remove secret
/edit remove configmap
commands that were previously missing support to specifying a namespace.// nolint:testpackage
comments, since those are not needed anymore after chore: disable testpackage linter #5448./kind bug