-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin tool versions with hack/go.mod #5622
Conversation
@karlkfi |
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sigh... why is this test depending on the response error code from example.com?? -_- |
@koba1t Rebased and passing tests now! |
/assign @koba1t |
HI @karlkfi So, I have one minor comment. Could you check that above? |
bf736d3
to
a9c2fc8
Compare
This change centralizes the tracking of versions for tools used for development and testing. This way, the tools and all their dependencies have their checksums stored in hack/go.sum, which improves supply chain security.
@koba1t I removed goreleaser and rebased. |
@koba1t please review |
Thanks for your great works! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change centralizes the tracking of versions for tools used for development and testing. This way, the tools and all their dependencies have their checksums stored in hack/go.sum, which improves supply chain security.
Depends on:
Go work sync & mod tidy are in a 2nd commit to make it easier to review the rest.