update go 1.24.6 #5959

koba1t · 2025-08-16T23:05:27Z

from go v1.22.7 to v1.24.6

k8s-ci-robot · 2025-08-16T23:05:29Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2025-08-16T23:05:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-08-16T23:25:31Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…nt@v1.64.8 to pass execute golangci-lint

koba1t · 2025-08-17T12:03:05Z

/retest

koba1t · 2025-08-17T12:40:32Z

/test kustomize-presubmit-master

koba1t · 2025-08-17T13:48:55Z

/hold wait a review from some reviewer/approver

koba1t · 2025-08-17T14:51:28Z

api/internal/builtins/AnnotationsTransformer.go

@@ -1,6 +1,4 @@
 // Code generated by pluginator on AnnotationsTransformer; DO NOT EDIT.
-// pluginator {(devel)  unknown   }


I removed pluginator's version line.
Since we're developing in the same repo, it should always be devel.

stormqueen1990

/lgtm
/unhold

kyaml/filesys/filesystem.go

stormqueen1990 · 2025-08-17T19:54:59Z

kyaml/fn/framework/command/command.go

 		Args: cobra.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			if err := os.WriteFile(filepath.Join(args[0], "Dockerfile"), []byte(`FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye as builder
+			if err := os.WriteFile(filepath.Join(args[0], "Dockerfile"), []byte(`FROM public.ecr.aws/docker/library/golang:1.24.6-bullseye as builder


Perhaps we could make this a constant somewhere?

There are multiple locations in go program where container image versions are specified, but since the packages are separated, making these constant values might be challenging.
https://github.com/search?q=repo%3Akubernetes-sigs%2Fkustomize++public.ecr.aws%2Fdocker%2Flibrary%2Fgolang%3A1.24.6-bullseye+language%3AGo&type=code&l=Go

therealdwright

Could you please cut a release of kustomize to get this out?

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.7.1` -> `v5.8.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.8.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.8.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.7.1...kustomize/v5.8.0) ### Highlights ##### implements to replacements value in the structured data Now, We can edit yaml/json in yaml manifests with replacements transformer. See [#5679](kubernetes-sigs/kustomize#5679) ##### For example ```yaml ## source apiVersion: v1 kind: ConfigMap metadata: name: source-configmap data: HOSTNAME: www.example.com --- apiVersion: v1 kind: ConfigMap metadata: name: target-configmap data: config.json: |- {"config": { "id": "42", "hostname": "REPLACE_TARGET_HOSTNAME" }} ``` ```yaml ## replacement replacements: - source: kind: ConfigMap name: source-configmap fieldPath: data.HOSTNAME targets: - select: kind: ConfigMap name: target-configmap fieldPaths: - data.config\.json.config.hostname ``` ##### fix: Propagate Namespace correctly to Helm The long-standing bug where kustomize's namespace transformer did not pass namespaces to helmCharts has been fixed. See [#5940](kubernetes-sigs/kustomize#5940) ##### For example ```yaml ## define namespace namespace: any-namespace helmCharts: - name: minecraft repo: https://kubernetes-charts.storage.googleapis.com version: v1.2.0 # namespace: any-namespace ## propagates without additional namespace specific valuesFile: values.yaml ``` #### Feature [#5679](kubernetes-sigs/kustomize#5679): implements to replacements value in the structured data [#5863](kubernetes-sigs/kustomize#5863): Add regex support for Replacement selectors [#5930](kubernetes-sigs/kustomize#5930): feat: add PatchArgs API type to populate patch options #### fix [#5940](kubernetes-sigs/kustomize#5940): fix: Propagate Namespace correctly to Helm [#5971](kubernetes-sigs/kustomize#5971): fix: performance recession when propagating namespace to helm [#5942](kubernetes-sigs/kustomize#5942): fix fnplugin storagemounts validation [#5958](kubernetes-sigs/kustomize#5958): fix: make AbsorbAll conflict error more verbose [#5961](kubernetes-sigs/kustomize#5961): refactor: nested format string [#5967](kubernetes-sigs/kustomize#5967): Fix infinite loop in HTTP client by validating URLs before requests [#5985](kubernetes-sigs/kustomize#5985): fix(kyaml/yaml): minor nil safety fix for RNode.Content etc [#5991](kubernetes-sigs/kustomize#5991): Fix duplicate key error when adding multiple labels with --without-selector #### Dependencies [#5962](kubernetes-sigs/kustomize#5962): chore: update dependencies from security alert [#5959](kubernetes-sigs/kustomize#5959): update go 1.24.6 #### chore [#6007](kubernetes-sigs/kustomize#6007): Update kyaml to v0.21.0 [#6008](kubernetes-sigs/kustomize#6008): Update cmd/config to v0.21.0 [#6009](kubernetes-sigs/kustomize#6009): Update api to v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

update go 1.24.6

ca938ec

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 16, 2025

k8s-ci-robot requested review from stormqueen1990 and varshaprasad96 August 16, 2025 23:05

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2025

koba1t mentioned this pull request Aug 16, 2025

Update go version for 1.24.6 in kustomize kubernetes/test-infra#35338

Merged

koba1t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 16, 2025

koba1t force-pushed the upgrade/go.1.24.6 branch from 3ed4cac to 5d95d2d Compare August 16, 2025 23:30

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2025

koba1t force-pushed the upgrade/go.1.24.6 branch from c568382 to 0d334ef Compare August 17, 2025 11:34

fix non-constant format string error

b320ec8

koba1t force-pushed the upgrade/go.1.24.6 branch from 0d334ef to 64f385d Compare August 17, 2025 11:41

update golang.org/x/tools@v0.36.0 and github.com/golangci/golangci-li…

7591346

…nt@v1.64.8 to pass execute golangci-lint

koba1t force-pushed the upgrade/go.1.24.6 branch from 64f385d to 7591346 Compare August 17, 2025 11:42

koba1t marked this pull request as ready for review August 17, 2025 11:50

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2025

add a verpose diff output to prow test

a9bb490

koba1t force-pushed the upgrade/go.1.24.6 branch from c01a93a to a9bb490 Compare August 17, 2025 12:14

remove pluginator binary version from generated files

7d63204

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2025

koba1t commented Aug 17, 2025

View reviewed changes

koba1t mentioned this pull request Aug 17, 2025

build(deps): bump golang.org/x/oauth2 from 0.25.0 to 0.27.0 in /hack #5946

Closed

stormqueen1990 reviewed Aug 17, 2025

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2025

k8s-ci-robot assigned stormqueen1990 Aug 17, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2025

k8s-ci-robot merged commit 87d0629 into kubernetes-sigs:master Aug 17, 2025
11 checks passed

This was referenced Aug 17, 2025

fix: upgrade go to 1.23.10 #5939

Closed

chore: bump to go 1.24 #5920

Closed

refactor: nested format string #5961

Merged

koba1t deleted the upgrade/go.1.24.6 branch August 17, 2025 21:36

This was referenced Aug 18, 2025

Upgrade to go 1.23.10 to patch CVE-2025-4673 #5941

Closed

Update go version to 1.24.4 to fix CVEs #5952

Closed

therealdwright reviewed Sep 6, 2025

View reviewed changes

koba1t mentioned this pull request Sep 29, 2025

security: upgrade Go toolchain to 1.24.4 to address CVE-2025-22871 #5957

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update go 1.24.6 #5959

update go 1.24.6 #5959

koba1t commented Aug 16, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t Aug 17, 2025 •

edited

Loading

Uh oh!

stormqueen1990 left a comment

Uh oh!

Uh oh!

stormqueen1990 Aug 17, 2025

Uh oh!

koba1t Aug 17, 2025

Uh oh!

Uh oh!

therealdwright left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,6 +1,4 @@
		// Code generated by pluginator on AnnotationsTransformer; DO NOT EDIT.
		// pluginator {(devel) unknown }

update go 1.24.6 #5959

update go 1.24.6 #5959

Conversation

koba1t commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t commented Aug 17, 2025

Uh oh!

koba1t Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stormqueen1990 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stormqueen1990 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

therealdwright left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

koba1t commented Aug 16, 2025 •

edited

Loading

koba1t Aug 17, 2025 •

edited

Loading