Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for releases #292

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add test for releases #292

merged 1 commit into from
Feb 17, 2023

Conversation

wzshiming
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@netlify
Copy link

netlify bot commented Feb 17, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 34097ec
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/63ef2e0bc1235500088d4cca

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2023
@wzshiming wzshiming mentioned this pull request Feb 17, 2023
Merged
@wzshiming wzshiming force-pushed the e2e/releases branch 5 times, most recently from 9056adf to f087353 Compare February 17, 2023 07:30
@wzshiming
Copy link
Member Author

/cc @zwpaper

@k8s-ci-robot
Copy link
Contributor

@wzshiming: GitHub didn't allow me to request PR reviews from the following users: zwpaper.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zwpaper

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zwpaper
Copy link
Member

zwpaper commented Feb 17, 2023

gotcha, I will update the build_image part to add nerdctl in #289 (comment) after this one merged

@wzshiming wzshiming merged commit 4344f2f into kubernetes-sigs:main Feb 17, 2023
@wzshiming wzshiming deleted the e2e/releases branch February 17, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzshiming @k8s-ci-robot @zwpaper